Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Riot Games Plugin #22

Merged
merged 5 commits into from
Jul 30, 2023
Merged

Riot Games Plugin #22

merged 5 commits into from
Jul 30, 2023

Conversation

ZenMaxe
Copy link
Contributor

@ZenMaxe ZenMaxe commented Jul 1, 2023

Added New Plugin

@tekgator
Copy link
Owner

@ZenMaxe sorry for the late response, I'm currently moving intercontinental, so haven't had a chance yet to look at everything in detail. I'll have some time the upcoming weekend and will merge.

@tekgator tekgator self-assigned this Jul 10, 2023
@tekgator tekgator added the enhancement New feature or request label Jul 10, 2023
@tekgator
Copy link
Owner

@ZenMaxe: Could you adjust the README's for the main project and add a README for the plugin?

@ZenMaxe
Copy link
Contributor Author

ZenMaxe commented Jul 11, 2023

@ZenMaxe: Could you adjust the README's for the main project and add a README for the plugin?

Sure

@ZenMaxe
Copy link
Contributor Author

ZenMaxe commented Jul 15, 2023

@tekgator i think it's ready now!

@tekgator tekgator self-requested a review July 30, 2023 03:12
tekgator
tekgator approved these changes Jul 30, 2023
View reviewed changes
Copy link
Owner

@tekgator tekgator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight issue on the Plugin ReadMe still pointing to another plugin, otherwise perfect.

@tekgator tekgator merged commit ee02be0 into tekgator:main Jul 30, 2023
1 check passed
@tekgator
Copy link
Owner

@ZenMaxe : the plugin has now been incorporated. Nuget 1.4.0 has now been released. Thanks for your effort. 👍

@ZenMaxe
Copy link
Contributor Author

ZenMaxe commented Aug 1, 2023

Slight issue on the Plugin ReadMe still pointing to another plugin, otherwise perfect.

Sorry, My Bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekgator tekgator tekgator approved these changes

Assignees

@tekgator tekgator

@ZenMaxe ZenMaxe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZenMaxe @tekgator