Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable linter for dependabot PRs #1206

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

lcarva
Copy link
Contributor

@lcarva lcarva commented Sep 17, 2024

Changes

Submitter Checklist

Because this repository uses vendored dependencies, and grouping for dependabot updates, the PRs created by dependabot are huge. This causes issues for the linter:
golangci/golangci-lint-action#996
The chances of dependabot creating new linting issues are minimal.

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

Because this repository uses vendored dependencies, and grouping for
dependabot updates, the PRs created by dependabot are huge. This causes
issues for the linter:
    golangci/golangci-lint-action#996
The chances of dependabot creating new linting issues are minimal.

Signed-off-by: Luiz Carvalho <[email protected]>
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 17, 2024
Copy link
Contributor

@chitrangpatel chitrangpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 17, 2024
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chitrangpatel, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lcarva
Copy link
Contributor Author

lcarva commented Sep 17, 2024

/test pull-tekton-chains-unit-tests

@lcarva
Copy link
Contributor Author

lcarva commented Sep 17, 2024

/retest-required

@tekton-robot tekton-robot merged commit 1e2519b into tektoncd:main Sep 17, 2024
17 checks passed
@lcarva lcarva deleted the disable-linter-dependabot branch September 17, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants