Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix link to vendor docs in README #939

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix link to vendor docs in README #939

merged 1 commit into from
Oct 25, 2023

Conversation

cguest97
Copy link
Contributor

Changes

Updated the link to the vendor docs to point towards the vendor directory in the Tekton Chains repository, previously this would redirect to https://github.com/docs/vendor which led to a 404 error.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 10, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cguest97 / name: Cameron Guest (aa0ec6d)

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2023
@tekton-robot
Copy link

Hi @cguest97. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cguest97 cguest97 force-pushed the vendorLink branch 2 times, most recently from 521c02e to 292309b Compare October 11, 2023 13:55
@cguest97
fix link to vendor docs in README
aa0ec6d 
Updated the link to the vendor docs to point towards the vendor directory in the Tekton Chains repository, previously this would redirect to https://github.com/docs/vendor which led to a 404 error.

Signed-off-by: Cameron Guest <[email protected]>
@wlynch
Copy link
Member

wlynch commented Oct 11, 2023

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 11, 2023
@cguest97
Copy link
Contributor Author

ready for review!

@wlynch wlynch mentioned this pull request Oct 25, 2023
Open
wlynch
wlynch approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it's more of a problem for the docs import (this does render properly on GitHub). Filed #967, but we'll merge this in to unbreak the upstream docs!

Thanks!

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2023
@tekton-robot tekton-robot merged commit 93c276b into tektoncd:main Oct 25, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlynch wlynch wlynch approved these changes

@chitrangpatel chitrangpatel Awaiting requested review from chitrangpatel

Assignees

@wlynch wlynch

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cguest97 @tekton-robot @wlynch