-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resolver support in tkn pr log commands #2083
Conversation
f5bde8b
to
8fe0cf6
Compare
8fe0cf6
to
fd8463f
Compare
@pratap0007 This seems very important feature to have e2e tests, at least for one resolver kind. Can you please add that? |
fd8463f
to
07235b8
Compare
This patch adds all type of resolver support for pipelinerun logs command closes: tektoncd#2016 Signed-off-by: Shiv Verma <[email protected]>
07235b8
to
0628079
Compare
/test pull-tekton-cli-integration-tests |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vinamra28 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test easycla |
@piyush-garg: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add resolver support for tkn pr logs command
This patch adds all type of resolver support for
pipelinerun logs command
closes: #2016
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make check
make generated
See the contribution guide
for more details.
Release Notes