Show error when there is an invalid filtered task #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
do-not-merge/release-note-label-needed
tekton-robot
added
size/XS
vdemeester
approved these changes
Aug 22, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
and show the available ones to make it easy to choose Signed-off-by: Chmouel Boudjnah <[email protected]>
chmouel
force-pushed
the
error-on-invalid-filtered-tasks
branch
from
45de500
to
8daa1d1
Compare
|
/lgtm |
|
@jkandasa: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
vinamra28
added a commit
that referenced
this pull request
Sep 8, 2023
#2090 | [Piyush Garg] Update release | 2023/08/01-18:00 #2094 | [dependabot[bot]] Bump golang.org/x/term from 0.10.0 to 0.11.0 | 2023/08/07-20:42 #2092 | [dependabot[bot]] Bump go.uber.org/zap from 1.24.0 to 1.25.0 | 2023/08/07-21:27 #2093 | [dependabot[bot]] Bump github.com/google/go-containerregistry from 0.15.2 to 0.16.1 | 2023/08/08-08:34 #2095 | [dependabot[bot]] Bump github.com/sigstore/sigstore from 1.7.1 to 1.7.2 | 2023/08/10-07:23 #2096 | [dependabot[bot]] Bump github.com/golangci/golangci-lint from 1.53.3 to 1.54.0 in /tools | 2023/08/10-08:35 #2098 | [dependabot[bot]] Bump github.com/theupdateframework/go-tuf from 0.6.0 to 0.6.1 | 2023/08/16-09:09 #2097 | [dependabot[bot]] Bump github.com/golangci/golangci-lint from 1.54.0 to 1.54.1 in /tools | 2023/08/17-07:33 #2101 | [dependabot[bot]] Bump github.com/golangci/golangci-lint from 1.54.1 to 1.54.2 in /tools | 2023/08/21-18:50 #2102 | [Chmouel Boudjnah] Show error when there is an invalid filtered task | 2023/08/22-14:34 null | [pratap0007] Bump tektoncd/pipeline to v0.50.0 LTS | 2023/08/24-11:24 null | [dependabot[bot]] Bump github.com/tektoncd/chains | 2023/08/24-13:36 null | [dependabot[bot]] Bump k8s.io/cli-runtime from 0.25.12 to 0.25.13 | 2023/08/24-14:38 null | [Zoran Regvart] Support for Manifest annotations in `bundle push` | 2023/08/28-06:44 null | [Piyush Garg] Bump triggers to v0.25.0 | 2023/08/29-11:18 null | [dependabot[bot]] Bump github.com/sigstore/sigstore from 1.7.2 to 1.7.3 | 2023/09/04-06:56 null | [dependabot[bot]] Bump golang.org/x/term from 0.11.0 to 0.12.0 | 2023/09/04-08:46 null | [Piyush Garg] Bump cosign to v2.2.0 and pin knative | 2023/09/04-13:32 null | [PuneetPunamiya] Bumps golang version to 1.20.7 | 2023/09/06-17:44 null | [PuneetPunamiya] Bumps Hub to v1.14.0 | 2023/09/07-20:12 null | [dependabot[bot]] Bump github.com/docker/docker | 2023/09/07-21:16 null | [dependabot[bot]] Bump github.com/docker/cli | 2023/09/08-02:08 Signed-off-by: vinamra28 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show an error on invalid task instead of looping forever (if -f is there) and show the available ones to make it easy to choose since name are not necessary obvious to know
Demo:
Release Note