Bump goreleaser version and optimize get-version #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
tekton-robot
added
the
size/S
vinamra28
force-pushed
the
improve-release-pipeline
branch
from
9936c24
to
7c7eed3
Compare
With go version v1.20.7, goreleaser version also need to be upgraded to v1.15.2. Also in get-version task we were running two steps and both the steps were using same image, hence merged both into a single step. Also the task was using goreleaser image which is more than 300M in size, instead using alpine/git which is ~21M Also use tkn hub install to install tasks from catalog so that we always use the latest one available Signed-off-by: vinamra28 <[email protected]>
With goreleaser version v1.14.0, archives.replacements and nfpms.replacements have been deprecated and we can leverage their respective name_template and file_name_template. Also the `replacements` property has been removed in v1.19.0. Updating goreleaser.yaml as per the suggested approach specified at https://goreleaser.com/deprecations/#archivesreplacements Signed-off-by: vinamra28 <[email protected]>
vinamra28
force-pushed
the
improve-release-pipeline
branch
from
7c7eed3
to
b233d50
Compare
tekton-robot
added
size/M
|
/lgtm |
|
/test pull-tekton-cli-integration-tests |
|
/retest |
piyush-garg
reviewed
Sep 21, 2023
piyush-garg
reviewed
Sep 21, 2023
piyush-garg
reviewed
Sep 21, 2023
piyush-garg
reviewed
Sep 21, 2023
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: piyush-garg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With go version v1.20.7, goreleaser version also need to be upgraded to v1.15.2.
Also in get-version task we were running two steps and both the steps were using same image, hence merged both into a single step. Also the task was using goreleaser image which is more than 300M in size, instead using alpine/git which is ~21M
Also use tkn hub install to install tasks from catalog so that we always use the latest one available
With goreleaser version v1.14.0, archives.replacements and
nfpms.replacements have been deprecated and we can leverage their
respective name_template and file_name_template. Also the
replacementsproperty has been removed in v1.19.0.
Updating goreleaser.yaml as per the suggested approach specified at
https://goreleaser.com/deprecations/#archivesreplacements
Signed-off-by: vinamra28 [email protected]
/kind misc
closes #2120
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes