Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add shorthand -a for --all flags #2412

Closed
wants to merge 1 commit into from

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Oct 11, 2024

Added shorthand 'a' for the --all flag in various delete commands which has a --all to improve usability and consistency across the CLI and with kubectl.

This change affects the following commands:

  • ClusterTriggerBinding delete
  • EventListener delete
  • Pipeline delete
  • PipelineRun delete
  • Task delete
  • TaskRun delete
  • TriggerBinding delete
  • TriggerTemplate delete

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

all commands with --all flag now has a a shorthand flag -a

Added shorthand 'a' for the --all flag in various delete commands which
has a --all to improve usability and consistency across the CLI and with
kubectl.

This change affects the following commands:

- ClusterTriggerBinding delete
- EventListener delete
- Pipeline delete
- PipelineRun delete
- Task delete
- TaskRun delete
- TriggerBinding delete
- TriggerTemplate delete

Signed-off-by: Chmouel Boudjnah <[email protected]>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 11, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from chmouel after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 11, 2024
@chmouel
Copy link
Member Author

chmouel commented Oct 14, 2024

/retest

@piyush-garg
Copy link
Contributor

piyush-garg commented Oct 17, 2024

Hey @chmouel

We were following here same like kubectl (1.30)

    --all=false:
	Delete all resources, in the namespace of the specified resource types.

    -A, --all-namespaces=false:
	If present, list the requested object(s) across all namespaces. Namespace in current context is ignored even
	if specified with --namespace.

In my opinion, -a short flag for --all does not help much from UX/usability view, but if @vdemeester @vinamra28 are fine, I am fine to get this in.

@vinamra28
Copy link
Member

I agree with @piyush-garg, --all is already short 😅

@chmouel
Copy link
Member Author

chmouel commented Oct 17, 2024

sounds good!

@chmouel chmouel closed this Oct 17, 2024
@chmouel chmouel deleted the add-a-as-alias-to-all branch October 17, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants