Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing actions to details pages #2261

Closed
AlanGreene opened this issue Dec 3, 2021 · 7 comments
Closed

Add missing actions to details pages #2261

AlanGreene opened this issue Dec 3, 2021 · 7 comments
Labels
kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone

Comments

@AlanGreene
Copy link
Member

AlanGreene commented Dec 3, 2021

There are some actions available on the PipelineRuns / TaskRuns list pages that are not available on the details pages for a single resource of those types, e.g. delete.

  • On the PipelineRun details page we currently display a 'Rerun' action in the top right corner of the header.
  • On TaskRun details, this is only present for standalone TaskRuns (i.e. not part of a PipelineRun).
  • We also have a 'Start' action that's displayed on PipelineRuns created in pending state.

Delete is conspicuously missing from this set of actions, and would be very useful so that users don't have to navigate back to the list, find the corresponding row, and click the delete action there.

Similarly once #2256 is delivered it would be nice to have access to the create action too.

Any actions available on a resource on the list page should also be available from the details page.

This will require some design work as we're also considering some changes to the existing TaskRun / PipelineRun details page structure.

@AlanGreene AlanGreene added kind/feature Categorizes issue or PR as related to a new feature. kind/design Categorizes issue or PR as related to design. labels Dec 3, 2021
@taechonkim
Copy link
Contributor

taechonkim commented Jan 30, 2022

@AlanGreene Happy New Year 🎉
I want to work on this issue, is there any docs about TaskRun / PipelineRun details page structure (you mentioned last line) before starting work?
plz assign this issue to me 😄

@AlanGreene
Copy link
Member Author

Thanks for your interest in this issue @taechonkim, however the design work for this has just started. It will likely be at least a few weeks before we have details to share and work can start on implementing the changes. I'll share more information as soon as it's available.

@taechonkim
Copy link
Contributor

Thanks for your interest in this issue @taechonkim, however the design work for this has just started. It will likely be at least a few weeks before we have details to share and work can start on implementing the changes. I'll share more information as soon as it's available.

@AlanGreene Hi, I wonder about the progress of the design work. If the work is done, I want to contribute this issue.

@AlanGreene
Copy link
Member Author

AlanGreene commented Apr 23, 2022

It's in progress. We'll share details here / issue #2306 as soon as it's ready to implement.

There's a lot to consider so it may take a while but we'll keep the issues updated with any progress.

@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 22, 2022
@AlanGreene
Copy link
Member Author

This is still something we want to do, freezing it so it doesn't get auto-closed.
/lifecycle frozen

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 22, 2022
@AlanGreene AlanGreene added this to the v0.29 milestone Aug 11, 2022
@AlanGreene
Copy link
Member Author

Closing as the PipelineRun, TaskRun, and Run (Custom Task) pages now support the same set of actions as the overflow menus on their respective list pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Categorizes issue or PR as related to design. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants