-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing actions on the TaskRun and PipelineRun details pages #2420
Conversation
Add ability to rerun/stop/delete etc. from the resource details page so that users no longer have to navigate to the list page to perform these actions. Replace use of the `RunAction` component (which only supported rerun and start actions) with the more generic `Actions` component which is already used on the list pages.
7e46f83
to
911d70c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
overall looks good, just wondering how the TileGroup looks
Would "Apply status" (or similar) for the heading on the group be an improvement? Just thinking that the past tense for the status, for a run that the user is in the process of cancelling, could be a little confusing |
Yeah we could tweak the wording and eventually I'd like to revisit the overall design and even the use of modals for stuff like this. This has already been in the latest release on the PipelineRuns page for 6 weeks now though and no complaints from users so far 🤞 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Related to #2261
Add ability to rerun/stop/delete etc. from the resource details page
so that users no longer have to navigate to the list page to perform
these actions.
Replace use of the
RunAction
component (which only supported rerunand start actions) with the more generic
Actions
component which isalready used on the list pages.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
See the contribution guide
for more details.