Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing actions on the TaskRun and PipelineRun details pages #2420

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

AlanGreene
Copy link
Member

Changes

Related to #2261

Add ability to rerun/stop/delete etc. from the resource details page
so that users no longer have to navigate to the list page to perform
these actions.

Replace use of the RunAction component (which only supported rerun
and start actions) with the more generic Actions component which is
already used on the list pages.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 23, 2022
@AlanGreene AlanGreene removed the request for review from skaegi August 23, 2022 18:15
Add ability to rerun/stop/delete etc. from the resource details page
so that users no longer have to navigate to the list page to perform
these actions.

Replace use of the `RunAction` component (which only supported rerun
and start actions) with the more generic `Actions` component which is
already used on the list pages.
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

overall looks good, just wondering how the TileGroup looks

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2022
@AlanGreene
Copy link
Member Author

just wondering how the TileGroup looks

It's the same as on the PipelineRuns list page

image

@briangleeson
Copy link
Contributor

just wondering how the TileGroup looks

It's the same as on the PipelineRuns list page

Would "Apply status" (or similar) for the heading on the group be an improvement? Just thinking that the past tense for the status, for a run that the user is in the process of cancelling, could be a little confusing

@AlanGreene
Copy link
Member Author

Yeah we could tweak the wording and eventually I'd like to revisit the overall design and even the use of modals for stuff like this. This has already been in the latest release on the PipelineRuns page for 6 weeks now though and no complaints from users so far 🤞

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2022
@tekton-robot tekton-robot merged commit dca571a into tektoncd:main Aug 25, 2022
@AlanGreene AlanGreene deleted the run_actions branch August 25, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants