-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assess the move to Triggers 0.2 (Dashboard) #918
Comments
Issues found when installing Triggers 0.2 after having the dashboard and extension and Triggers 0.1 already installed: No displaying of Trigger resources Failed to load resource: the server responded with a status of 404 (Not Found) Actually proxy/apis/apiextensions.k8s.io/v1beta1/customresourcedefinitions/ seeing this with 0.1 too on OpenShift. #919 created |
Fix for trigger resource displaying on OpenShift #920 I'll look at the rest once I've got an EventListener with webhooks as per tektoncd/experimental#431, there may be other fields in Triggers 0.2 but we won't worry about those just yet unless we're erroring |
@ncskier and I have been contemplating and testing this, so with an EventListener made with 0.1, and then with Triggers 0.2 installed, everything appears great - including TriggerTemplates and TriggerBindings. We think there'll be a problem when we have multiple interceptors (in that they won't be picked up from the array, as you can now have multiple) and the same principle applies for bindings (of which there can now be multiple). |
@kimholmes hey Kim, here's the item for assessing the Triggers 0.2 move - so once this is done and someone wants to implement 0.2 support, please work with @kimholmes and co on progressing this item forwards. We're thinking of doing the move to Triggers 0.2 after we move to Pipelines 0.10. |
I think Adam pretty much covered everything we'll need to update; here's a summary so we can view everything all at once (let me know if I missed anything): TriggerTemplate list & details pagesNo change TriggerBinding list & details pagesNo change EventListener details page
EventListener list pageNo change |
Thank you @a-roberts and @ncskier |
Assessments done so I'll make follow-up issue(s) for getting it in, keeping #937 in mind |
As an end user I expect to be able to use the Tekton Dashboard with Triggers 0.2. When using the webhooks extension there's a fundamental flaw with our architecture too - a user can't create more than eight webhooks or they'll get an admission webhook timeout error (more details at tektoncd/triggers#356)
Related webhooks issue tektoncd/experimental#431
The text was updated successfully, but these errors were encountered: