Assess the move to Triggers 0.2 (webhooks)

[a-roberts]

As an end user I expect to be able to use the Tekton Dashboard with Triggers 0.2. When using the webhooks extension there's a fundamental flaw with our architecture too - a user can't create more than eight webhooks or they'll get an admission webhook timeout error (more details at tektoncd/triggers#356)

Related dashboard issue tektoncd/dashboard#918

[a-roberts]

Can't create webhooks

Error:

Failed to create webhook, error returned was : error creating webhook due to error creating eventlistener. Error was: Internal error occurred: admission webhook "triggers-webhook.tekton.dev" denied the request: mutation failed: cannot decode incoming new object: json: unknown field "header"

https://github.com/tektoncd/triggers/blob/master/pkg/apis/triggers/v1alpha1/event_listener_types.go#L96 perhaps

[a-roberts]

I pinged @ncskier about this, Brandon mentioned

experimental/webhooks-extension/pkg/endpoints/webhook.go

Line 152 in 1ccc14e

Params: params,

We do use params, but now in Triggers 0.2 they don't exist - we have to create a separate TriggerBinding resource for them. There should be an issue floating around somewhere for embedding the TriggerBinding spec in the EventListener, but it hasn’t been implemented yet (this is missing in the Triggers release notes atm)

[ncskier]

Another change to note (discussed in the Triggers call today) is that the gjson syntax will no longer be supported; instead we must use JSONPath syntax:

gjson syntax for TriggerBindings was removed in favor of JSONPath.

This is not a problem for the Webhooks Extension itself, but anyone using the Webhooks Extension will have to update their TriggerBindings to use the JSONPath syntax.

[a-roberts]

Assessment done for what we can do so far, closing