TaskRuns should have a rendering for retries

[steveodonovan]

Expected behavior

The taskRun tree should have some output for retried taskRuns

Actual behavior

From the dashboard pov it looks like just the one taskRun and run.

Additional Info

Sample taskRun Resource with retries

"cutting-down-trees-runnnpjd-task2-gx2bj": {
            "pipelineTaskName": "task2",
            "status": {
              "conditions": [
                {
                  "type": "Succeeded",
                  "status": "False",
                  "lastTransitionTime": "2020-01-22T14:40:14Z",
                  "reason": "Failed",
                  "message": "\"step-task-two-step-one\" exited with code 1 (image: \"docker-pullable://ubuntu@sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110\"); for logs run: kubectl -n pw-be59be20-00d7-4187-afd8-997d2db63b4e logs cutting-down-trees-runnnpjd-task2-gx2bj-pod-95956e -c step-task-two-step-one"
                }
              ],
              "podName": "cutting-down-trees-runnnpjd-task2-gx2bj-pod-95956e",
              "startTime": "2020-01-22T14:40:07Z",
              "completionTime": "2020-01-22T14:40:14Z",
              "steps": [
                {
                  "terminated": {
                    "exitCode": 1,
                    "reason": "Error",
                    "startedAt": "2020-01-22T14:40:13Z",
                    "finishedAt": "2020-01-22T14:40:14Z",
                    "containerID": "docker://95d0e6b72578e01d797b5314d3af39fbc97856e5cff9ffec474216ee9324276e"
                  },
                  "name": "task-two-step-one",
                  "container": "step-task-two-step-one",
                  "imageID": "docker-pullable://ubuntu@sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110"
                }
              ],
              "retriesStatus": [
                {
                  "conditions": [
                    {
                      "type": "Succeeded",
                      "status": "False",
                      "lastTransitionTime": "2020-01-22T14:39:07Z",
                      "reason": "Failed",
                      "message": "\"step-task-two-step-one\" exited with code 1 (image: \"docker-pullable://ubuntu@sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110\"); for logs run: kubectl -n pw-be59be20-00d7-4187-afd8-997d2db63b4e logs cutting-down-trees-runnnpjd-task2-gx2bj-pod-369c2b -c step-task-two-step-one"
                    }
                  ],
                  "podName": "cutting-down-trees-runnnpjd-task2-gx2bj-pod-369c2b",
                  "startTime": "2020-01-22T14:38:59Z",
                  "completionTime": "2020-01-22T14:39:07Z",
                  "steps": [
                    {
                      "terminated": {
                        "exitCode": 1,
                        "reason": "Error",
                        "startedAt": "2020-01-22T14:39:05Z",
                        "finishedAt": "2020-01-22T14:39:06Z",
                        "containerID": "docker://a30d49879b8fd88e3bb1a26e81de8e517b7330201df874f02df5775ab6893afa"
                      },
                      "name": "task-two-step-one",
                      "container": "step-task-two-step-one",
                      "imageID": "docker-pullable://ubuntu@sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110"
                    }
                  ]
                },
                {
                  "conditions": [
                    {
                      "type": "Succeeded",
                      "status": "False",
                      "lastTransitionTime": "2020-01-22T14:39:15Z",
                      "reason": "Failed",
                      "message": "\"step-task-two-step-one\" exited with code 1 (image: \"docker-pullable://ubuntu@sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110\"); for logs run: kubectl -n pw-be59be20-00d7-4187-afd8-997d2db63b4e logs cutting-down-trees-runnnpjd-task2-gx2bj-pod-d67586 -c step-task-two-step-one"
                    }
                  ],
                  "podName": "cutting-down-trees-runnnpjd-task2-gx2bj-pod-d67586",
                  "startTime": "2020-01-22T14:39:07Z",
                  "completionTime": "2020-01-22T14:39:15Z",
                  "steps": [
                    {
                      "terminated": {
                        "exitCode": 1,
                        "reason": "Error",
                        "startedAt": "2020-01-22T14:39:13Z",
                        "finishedAt": "2020-01-22T14:39:14Z",
                        "containerID": "docker://9ce4e896ae1d8cb44020a69d26c3a8bb17a45ec794e15134a0bc0805aa9b12a7"
                      },
                      "name": "task-two-step-one",
                      "container": "step-task-two-step-one",
                      "imageID": "docker-pullable://ubuntu@sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110"
                    }
                  ]
                },
                {
                  "conditions": [
                    {
                      "type": "Succeeded",
                      "status": "False",
                      "lastTransitionTime": "2020-01-22T14:39:25Z",
                      "reason": "Failed",
                      "message": "\"step-task-two-step-one\" exited with code 1 (image: \"docker-pullable://ubuntu@sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110\"); for logs run: kubectl -n pw-be59be20-00d7-4187-afd8-997d2db63b4e logs cutting-down-trees-runnnpjd-task2-gx2bj-pod-219134 -c step-task-two-step-one"
                    }
                  ],
                  "podName": "cutting-down-trees-runnnpjd-task2-gx2bj-pod-219134",
                  "startTime": "2020-01-22T14:39:15Z",
                  "completionTime": "2020-01-22T14:39:25Z",
                  "steps": [
                    {
                      "terminated": {
                        "exitCode": 1,
                        "reason": "Error",
                        "startedAt": "2020-01-22T14:39:22Z",
                        "finishedAt": "2020-01-22T14:39:25Z",
                        "containerID": "docker://f8584727c1e66f2f45e708844daee2fd421a94c2afae83534befad9875769344"
                      },
                      "name": "task-two-step-one",
                      "container": "step-task-two-step-one",
                      "imageID": "docker-pullable://ubuntu@sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110"
                    }
                  ]
                },
                {
                  "conditions": [
                    {
                      "type": "Succeeded",
                      "status": "False",
                      "lastTransitionTime": "2020-01-22T14:39:32Z",
                      "reason": "Failed",
                      "message": "\"step-task-two-step-one\" exited with code 1 (image: \"docker-pullable://ubuntu@sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110\"); for logs run: kubectl -n pw-be59be20-00d7-4187-afd8-997d2db63b4e logs cutting-down-trees-runnnpjd-task2-gx2bj-pod-e92c43 -c step-task-two-step-one"
                    }
                  ],
                  "podName": "cutting-down-trees-runnnpjd-task2-gx2bj-pod-e92c43",
                  "startTime": "2020-01-22T14:39:25Z",
                  "completionTime": "2020-01-22T14:39:32Z",
                  "steps": [
                    {
                      "terminated": {
                        "exitCode": 1,
                        "reason": "Error",
                        "startedAt": "2020-01-22T14:39:30Z",
                        "finishedAt": "2020-01-22T14:39:31Z",
                        "containerID": "docker://ffc032ea40a73ba50d74e3c26ea1a6170d6387fa7f4991af4bcbda9c88377f72"
                      },
                      "name": "task-two-step-one",
                      "container": "step-task-two-step-one",
                      "imageID": "docker-pullable://ubuntu@sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110"
                    }
                  ]
                },
                {
                  "conditions": [
                    {
                      "type": "Succeeded",
                      "status": "False",
                      "lastTransitionTime": "2020-01-22T14:39:42Z",
                      "reason": "Failed",
                      "message": "\"step-task-two-step-one\" exited with code 1 (image: \"docker-pullable://ubuntu@sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110\"); for logs run: kubectl -n pw-be59be20-00d7-4187-afd8-997d2db63b4e logs cutting-down-trees-runnnpjd-task2-gx2bj-pod-657efc -c step-task-two-step-one"
                    }
                  ],
                  "podName": "cutting-down-trees-runnnpjd-task2-gx2bj-pod-657efc",
                  "startTime": "2020-01-22T14:39:32Z",
                  "completionTime": "2020-01-22T14:39:42Z",
                  "steps": [
                    {
                      "terminated": {
                        "exitCode": 1,
                        "reason": "Error",
                        "startedAt": "2020-01-22T14:39:38Z",
                        "finishedAt": "2020-01-22T14:39:41Z",
                        "containerID": "docker://e3392111e5b7d109be4781daf4fd552f5330fa59c6c4717d116b7790a9bd165a"
                      },
                      "name": "task-two-step-one",
                      "container": "step-task-two-step-one",
                      "imageID": "docker-pullable://ubuntu@sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110"
                    }
                  ]
                },
                {
                  "conditions": [
                    {
                      "type": "Succeeded",
                      "status": "False",
                      "lastTransitionTime": "2020-01-22T14:39:51Z",
                      "reason": "Failed",
                      "message": "\"step-task-two-step-one\" exited with code 1 (image: \"docker-pullable://ubuntu@sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110\"); for logs run: kubectl -n pw-be59be20-00d7-4187-afd8-997d2db63b4e logs cutting-down-trees-runnnpjd-task2-gx2bj-pod-8f4a71 -c step-task-two-step-one"
                    }
                  ],
                  "podName": "cutting-down-trees-runnnpjd-task2-gx2bj-pod-8f4a71",
                  "startTime": "2020-01-22T14:39:42Z",
                  "completionTime": "2020-01-22T14:39:51Z",
                  "steps": [
                    {
                      "terminated": {
                        "exitCode": 1,
                        "reason": "Error",
                        "startedAt": "2020-01-22T14:39:47Z",
                        "finishedAt": "2020-01-22T14:39:49Z",
                        "containerID": "docker://17ca3b3a8a42cd4396f63aa85554ef9b424274b2bdea357a14380cb9f4219938"
                      },
                      "name": "task-two-step-one",
                      "container": "step-task-two-step-one",
                      "imageID": "docker-pullable://ubuntu@sha256:8d31dad0c58f552e890d68bbfb735588b6b820a46e459672d96e585871acc110"
                    }
                  ]
                },

[steveodonovan]

/assign

[AlanGreene]

This is something we should look at as part of / after the move to the new design for the run details page: #675 (comment)

We should work with design to figure out how to incorporate information about the retries. I'm not sure if they warrant their own item at the top level of the accordion, or if they should be surfaced in some other way.

Does the run.status.conditions get updated with results of the current / most recent retry? If so, we should be ok for displaying in-progress runs, but would need to provide access to details of previous retries. It would be good to at least have some indication on the task tree that a retry has taken place as a first step.

[steveodonovan]

/assign