-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rendering for retried taskRuns #1439
Conversation
Some of the discussion about the sorting is on the original PR here #1077 but I don't think it was all captured 😿 There was an issue with the TaskRun times in some cases, but we've had Tekton Pipelines 0.11 and 0.12 released since then (end of Feb) with many potentially relevant changes in that area so probably worth revisiting that decision. |
9ffaca3
to
63a96c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion on the string id, otherwise code looks good
testing this out now and so far it's working great!
retryPodIndex[podName] || taskRun.status.retriesStatus.length; | ||
pipelineTaskName = intl.formatMessage( | ||
{ | ||
id: 'dashboard.pipelineRun.pipelineTaskName.retryAppendage', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
id: 'dashboard.pipelineRun.pipelineTaskName.retryAppendage', | |
id: 'dashboard.pipelineRun.pipelineTaskName.retry', |
63a96c3
to
e9cac7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlanGreene The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
#936
Adds a rendering for taskRun retries.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
One thing to follow up on. Why do we sort by step started time on the taskRun tree. https://github.com/tektoncd/dashboard/blob/master/packages/components/src/components/PipelineRun/PipelineRun.js#L67
The values can be blank - below is a sample