Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front End Development for Triggers UI #937

Open
kimholmes opened this issue Jan 22, 2020 · 15 comments
Open

Front End Development for Triggers UI #937

kimholmes opened this issue Jan 22, 2020 · 15 comments
Labels
kind/design Categorizes issue or PR as related to design. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@kimholmes
Copy link

kimholmes commented Jan 22, 2020

This issue provides front end development specifications to build the Triggers UI of the dashboard. These designs are based on UX iterations between the design and development teams and are based on previous design specs located under this Epic:

#675
The design contact is @ carrenelloyd

TriggerTemplate_Details
TriggerTemplate_DetailsSpec
EventListener_Detail
EventListener_DetailSpec

@carrenelloyd
Copy link

Please ping me on Slack with any questions.
Slack: @carrie

@kimholmes
Copy link
Author

@carlos-logro @AlanGreene

@ncskier
Copy link
Member

ncskier commented Feb 4, 2020

I just noticed that the Triggers | YAML toggle menu should probably be a Triggers header. Instead, the toggle button should be at the top of the page, and it should read Details | YAML to match the toggles we have in the rest of the pages:
Screen Shot 2020-02-04 at 11 08 08 AM

The current layout will look weird when switching to the YAML view, because the entire page becomes YAML:
Screen Shot 2020-02-04 at 11 10 43 AM

@kimholmes
Copy link
Author

kimholmes commented Feb 5, 2020

@ncskier Just had a conversation with Carrie, the viz designer and she reminded me that we did decide to move those tabs down. The reasoning behind it was that, if we have a Details tab up top, it will be very sparse. So, we decided we didn't need a Details tab and that resulted in moving the tabs below the Details content.

@carrenelloyd
Copy link

  1. Added Details subheader below Tabs
  2. $productive-heading-02
  3. 24 spacing token above and below the Details text

image

image

@tekton-robot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Aug 13, 2020
@tekton-robot
Copy link
Contributor

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene
Copy link
Member

/remove-lifecycle rotten
/reopen

@tekton-robot tekton-robot reopened this Aug 13, 2020
@tekton-robot
Copy link
Contributor

@AlanGreene: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene
Copy link
Member

/remove-lifecycle stale

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 13, 2020
@AlanGreene
Copy link
Member

We should also consider how a user will navigate between Triggers resources and the resulting Pipelines resources.
This has come up a number of times, most recently in https://tektoncd.slack.com/archives/CHTHGRQBC/p1602508229019000. Although that question was initially focused on the Pipeline visualisation it makes sense to consider how it would affect navigation and the presentation of the Triggers resources too.

@AlanGreene AlanGreene added the kind/design Categorizes issue or PR as related to design. label Dec 2, 2020
@tekton-robot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 2, 2021
@AlanGreene
Copy link
Member

/lifecycle frozen

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 2, 2021
@tekton-robot tekton-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Categorizes issue or PR as related to design. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Status: Todo
Development

No branches or pull requests

5 participants