-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TaskRun results tab #1965
Add TaskRun results tab #1965
Conversation
d39e87b
to
bc50860
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small suggestion. Otherwise looks good 👍
packages/components/src/components/TaskRunDetails/TaskRunDetails.test.js
Show resolved
Hide resolved
Add a tab to display TaskRun results as a sibling of Parameters and Status when a user clicks on the TaskRun in the TaskTree component. Similar to Parameters, this is only displayed when there are results to display.
bc50860
to
231eddf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: steveodonovan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
#1943
Add a tab to display TaskRun results as a sibling of Parameters
and Status when a user clicks on the TaskRun in the TaskTree
component. Similar to Parameters, this is only displayed when
there are results to display.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.