Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TaskRun results tab #1965

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Conversation

AlanGreene
Copy link
Member

Changes

#1943

Add a tab to display TaskRun results as a sibling of Parameters
and Status when a user clicks on the TaskRun in the TaskTree
component. Similar to Parameters, this is only displayed when
there are results to display.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 3, 2021
Copy link
Member

@steveodonovan steveodonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small suggestion. Otherwise looks good 👍

Add a tab to display TaskRun results as a sibling of Parameters
and Status when a user clicks on the TaskRun in the TaskTree
component. Similar to Parameters, this is only displayed when
there are results to display.
Copy link
Member

@steveodonovan steveodonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2021
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: steveodonovan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2021
@tekton-robot tekton-robot merged commit 5e9a128 into tektoncd:main Mar 4, 2021
@AlanGreene AlanGreene deleted the taskrun_results branch March 4, 2021 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants