Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start adopting React Router v6 API using compatibility layer #2542

Merged
merged 1 commit into from
Oct 27, 2022

Commits on Oct 21, 2022

  1. Start adopting React Router v6 API using compatibility layer

    React Router v6 contains a number of breaking changes, however they
    have provided a helpful compatibility layer which allows us to start
    adopting the new APIs while still using v5. This means we don't have
    to update everything in one go (which would also require updating to
    React 18).
    
    Change implemented so far:
    - use hooks from new API, `useHistory` replaced by `useNavigate`
    - no standalone `Route` components, must be inside a `Switch`
    - use `CompatRoute` to begin consuming the new APIs
    - implement replacement for `useRouteMatch` from v5 which is not
      available in the new API. This also allows us to clean up the
      `NamespacedRoute` and related `namespacedMatch` used for navigation
      when switching namespaces avoiding the need to explicitly pass
      the `allNamespacesPath` on each namespaced resource details page.
    AlanGreene committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    2112801 View commit details
    Browse the repository at this point in the history