Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete extensions pages and related code #3422

Merged
merged 1 commit into from
May 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions packages/utils/src/utils/router.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,6 @@ export const paths = {
return byNamespace({ path: '/eventlisteners' });
}
},
extensions: {
all() {
return '/extensions';
},
byName({ name }) {
return `/extensions/${name}`;
}
},
importResources() {
return '/importresources';
},
Expand Down
13 changes: 0 additions & 13 deletions packages/utils/src/utils/router.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,19 +111,6 @@ describe('eventListeners', () => {
});
});

describe('extensions', () => {
it('all', () => {
expect(urls.extensions.all()).toEqual(generatePath(paths.extensions.all()));
});

it('byName', () => {
const name = 'name';
expect(urls.extensions.byName({ name })).toEqual(
generatePath(paths.extensions.byName({ name }), { name })
);
});
});

it('importResources', () => {
expect(urls.importResources()).toEqual(generatePath(paths.importResources()));
});
Expand Down
20 changes: 1 addition & 19 deletions src/containers/App/App.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ import {
CustomRuns,
EventListener,
EventListeners,
Extension,
Extensions,
HeaderBarContent,
ImportResources,
Interceptors,
Expand Down Expand Up @@ -166,7 +164,7 @@ export function App({ lang }) {
const showLoadingState = isPropertiesPlaceholder || isMessagesPlaceholder;
const isFetchingConfig = isFetchingProperties || isFetchingMessages;

const { data: extensions = [], isWebSocketConnected } = useExtensions(
const { isWebSocketConnected } = useExtensions(
{ namespace: tenantNamespaces[0] || ALL_NAMESPACES },
{ enabled: !isFetchingConfig }
);
Expand Down Expand Up @@ -446,22 +444,6 @@ export function App({ lang }) {
<CompatRoute path={paths.clusterInterceptors.all()} exact>
<ClusterInterceptors />
</CompatRoute>
<CompatRoute path={paths.extensions.all()} exact>
<Extensions />
</CompatRoute>
{extensions
.filter(extension => !extension.type)
.map(({ displayName, name, source }) => (
<CompatRoute
key={name}
path={paths.extensions.byName({ name })}
>
<Extension
displayName={displayName}
source={source}
/>
</CompatRoute>
))}
<CompatRoute path={paths.rawCRD.byNamespace()} exact>
<NamespacedRoute isResourceDetails>
<CustomResourceDefinition />
Expand Down
57 changes: 0 additions & 57 deletions src/containers/Extension/Extension.jsx

This file was deleted.

23 changes: 0 additions & 23 deletions src/containers/Extension/globals.js

This file was deleted.

15 changes: 0 additions & 15 deletions src/containers/Extension/index.js

This file was deleted.

109 changes: 0 additions & 109 deletions src/containers/Extensions/Extensions.jsx

This file was deleted.

15 changes: 0 additions & 15 deletions src/containers/Extensions/index.js

This file was deleted.

4 changes: 1 addition & 3 deletions src/containers/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
Copyright 2019-2023 The Tekton Authors
Copyright 2019-2024 The Tekton Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
Expand All @@ -25,8 +25,6 @@ export { default as CustomRun } from './CustomRun';
export { default as CustomRuns } from './CustomRuns';
export { default as EventListener } from './EventListener';
export { default as EventListeners } from './EventListeners';
export { default as Extension } from './Extension';
export { default as Extensions } from './Extensions';
export { default as HeaderBarContent } from './HeaderBarContent';
export { default as ImportResources } from './ImportResources';
export { default as Interceptors } from './Interceptors';
Expand Down
3 changes: 0 additions & 3 deletions src/nls/messages_de.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,6 @@
"dashboard.eventListener.namespaceSelector": "",
"dashboard.eventListener.serviceAccount": "",
"dashboard.eventListener.serviceType": "",
"dashboard.extension.error": "",
"dashboard.extensions.emptyState": "",
"dashboard.extensions.errorLoading": "",
"dashboard.extensions.title": "",
"dashboard.filter.all": "",
"dashboard.filter.status.title": "",
Expand Down
3 changes: 0 additions & 3 deletions src/nls/messages_en.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,6 @@
"dashboard.eventListener.namespaceSelector": "Namespace selector:",
"dashboard.eventListener.serviceAccount": "ServiceAccount:",
"dashboard.eventListener.serviceType": "Service type:",
"dashboard.extension.error": "Error loading extension",
"dashboard.extensions.emptyState": "No extensions found",
"dashboard.extensions.errorLoading": "Error loading extensions",
"dashboard.extensions.title": "Extensions",
"dashboard.filter.all": "All",
"dashboard.filter.status.title": "Status:",
Expand Down
3 changes: 0 additions & 3 deletions src/nls/messages_es.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,6 @@
"dashboard.eventListener.namespaceSelector": "",
"dashboard.eventListener.serviceAccount": "",
"dashboard.eventListener.serviceType": "",
"dashboard.extension.error": "",
"dashboard.extensions.emptyState": "",
"dashboard.extensions.errorLoading": "",
"dashboard.extensions.title": "",
"dashboard.filter.all": "",
"dashboard.filter.status.title": "",
Expand Down
3 changes: 0 additions & 3 deletions src/nls/messages_fr.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,6 @@
"dashboard.eventListener.namespaceSelector": "",
"dashboard.eventListener.serviceAccount": "",
"dashboard.eventListener.serviceType": "",
"dashboard.extension.error": "",
"dashboard.extensions.emptyState": "",
"dashboard.extensions.errorLoading": "",
"dashboard.extensions.title": "",
"dashboard.filter.all": "",
"dashboard.filter.status.title": "",
Expand Down
3 changes: 0 additions & 3 deletions src/nls/messages_it.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,6 @@
"dashboard.eventListener.namespaceSelector": "",
"dashboard.eventListener.serviceAccount": "",
"dashboard.eventListener.serviceType": "",
"dashboard.extension.error": "",
"dashboard.extensions.emptyState": "",
"dashboard.extensions.errorLoading": "",
"dashboard.extensions.title": "",
"dashboard.filter.all": "",
"dashboard.filter.status.title": "",
Expand Down
3 changes: 0 additions & 3 deletions src/nls/messages_ja.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,6 @@
"dashboard.eventListener.namespaceSelector": "Namespace Selector:",
"dashboard.eventListener.serviceAccount": "ServiceAccount:",
"dashboard.eventListener.serviceType": "Service Type:",
"dashboard.extension.error": "拡張機能のロード中にエラーが発生しました",
"dashboard.extensions.emptyState": "拡張機能なし",
"dashboard.extensions.errorLoading": "拡張機能のロード中にエラーが発生しました",
"dashboard.extensions.title": "拡張機能",
"dashboard.filter.all": "すべて",
"dashboard.filter.status.title": "ステータス:",
Expand Down
3 changes: 0 additions & 3 deletions src/nls/messages_ko.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,6 @@
"dashboard.eventListener.namespaceSelector": "네임스페이스 선택기:",
"dashboard.eventListener.serviceAccount": "서비스 계정:",
"dashboard.eventListener.serviceType": "서비스 종류:",
"dashboard.extension.error": "확장 프로그램을 로드하는 중에 오류가 발생했습니다.",
"dashboard.extensions.emptyState": "확장 프로그램이 없습니다.",
"dashboard.extensions.errorLoading": "확장 프로그램을 로드하는 중에 오류가 발생했습니다.",
"dashboard.extensions.title": "확장 프로그램",
"dashboard.filter.all": "모두",
"dashboard.filter.status.title": "상태:",
Expand Down
3 changes: 0 additions & 3 deletions src/nls/messages_pt.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,6 @@
"dashboard.eventListener.namespaceSelector": "",
"dashboard.eventListener.serviceAccount": "",
"dashboard.eventListener.serviceType": "",
"dashboard.extension.error": "Erro ao carregar extensão",
"dashboard.extensions.emptyState": "Nenhuma extensão encontrada",
"dashboard.extensions.errorLoading": "Erro ao carregar extensão",
"dashboard.extensions.title": "",
"dashboard.filter.all": "",
"dashboard.filter.status.title": "",
Expand Down
Loading
Loading