Refactor Header and SideNav for easier packaging as a static route #3440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/misc
Refactor the Header and SideNav components so that they can be more easily consumed as part of a statically defined route using the new React Router data APIs. This means the header and logout button are no longer pure UI components, and are moved to the containers folder instead, so they can use Dashboard-specific APIs and data as needed. These components are quite specific to the Dashboard application anyway so didn't really make sense as pure UI components in the first place.
AlanGreene
force-pushed
the
header_refactor
branch
from
31b52f9
to
0681b40
Compare
|
/test all |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#2452
Refactor the Header and SideNav components so that they can be more
easily consumed as part of a statically defined route using the new
React Router data APIs. This means the header and logout button are
no longer pure UI components, and are moved to the containers folder
instead, so they can use Dashboard-specific APIs and data as needed.
These components are quite specific to the Dashboard application
anyway so didn't really make sense as pure UI components in the first
place.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes