Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update graph styles #808

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Update graph styles #808

merged 1 commit into from
Dec 6, 2019

Conversation

AlanGreene
Copy link
Member

@AlanGreene AlanGreene commented Dec 6, 2019 •
edited
Loading

Changes

Addresses most of the items from #675 (comment)

  • Increase item height to 30px
  • Increase icon size to 20px
  • Update colours of edges, arrows, and default text / outlines
  • Update spacing of elements in node labels
  • Avoid duplicating the marker (arrow) definition
  • Update arrow definition to produce a cleaner shape when zoomed
  • Set fixed width for nodes at 200px
  • Switch to center truncation on long labels

Remaining:

  • variable width nodes
  • position chevron relative to label text
  • remove unwanted space at bottom of expanded TaskRuns with multiple steps

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 6, 2019
@AlanGreene
Update graph styles
288179b 
- Increase item height to 30px
- Increase icon size to 20px
- Update colours of edges, arrows, and default text / outlines
- Update spacing of elements in node labels
- Avoid duplicating the marker (arrow) definition
- Update arrow definition to produce a cleaner shape when zoomed
- Set fixed width for nodes at 200px
- Switch to center truncation on long labels
steveodonovan
steveodonovan approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@steveodonovan steveodonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2019
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: steveodonovan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2019
@tekton-robot tekton-robot merged commit 6d52b2d into tektoncd:master Dec 6, 2019
@AlanGreene AlanGreene deleted the graph_style_tweaks branch December 6, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveodonovan steveodonovan steveodonovan approved these changes

@CarolynMabbott CarolynMabbott Awaiting requested review from CarolynMabbott

@dibbles dibbles Awaiting requested review from dibbles

Assignees

@steveodonovan steveodonovan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlanGreene @tekton-robot @steveodonovan