-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert rbac optim #2348
Revert rbac optim #2348
Conversation
The following is the coverage report on the affected files.
|
… rbac reconciliation for openshift
3fc17eb
to
30d755a
Compare
The following is the coverage report on the affected files.
|
Tested locally by upgrading from release-v0.71.x to this PR changes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: savitaashture The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/cherry-pick release-v0.73.x |
@jkhelil: new pull request created: #2349 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
CreateResource function is ensuring rbac resource for opensift namespaces. When implemented through concurrency, we observed unstability due the fact that concurrent workers tries to update a shared object clusterinterceptor cluster role binding. concurrency seems not bring improvement in performance, and bring unstability
The fix reverts concurrency implementation and fixes the creates resource function to not block the hole reconciliation when an issue is observed for one namespace
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lint
before submitting a PRSee the contribution guide for more details.
Release Notes