Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cluster task installersets #2376

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove cluster task installersets #2376

wants to merge 1 commit into from

Conversation

pratap0007
Copy link
Contributor

@pratap0007 pratap0007 commented Oct 16, 2024 •
edited
Loading

Changes

This patch will remove cluster task installersets and also
remove the existing cluster task installersets during operator upgrade

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 16, 2024
@tekton-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 16, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign vdemeester after the PR has been reviewed.
You can assign the PR to them by writing /assign @vdemeester in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pratap0007 pratap0007 changed the title [WIP]Remove cluster task installersets Remove creation of cluster task installersets Oct 18, 2024
@pratap0007 pratap0007 marked this pull request as ready for review October 18, 2024 13:11
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2024
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/cluster_task.go 39.1% 100.0% 60.9
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 47.9% 5.3

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/cluster_task.go 39.1% 100.0% 60.9
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 47.9% 5.3

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/cluster_task.go 39.1% 100.0% 60.9
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 47.9% 5.3

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/cluster_task.go 39.1% 100.0% 60.9
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 47.9% 5.3

@vdemeester
Copy link
Member

cc @jkandasa

@pratap0007 pratap0007 changed the title Remove creation of cluster task installersets [WIP] Remove creation of cluster task installersets Nov 5, 2024
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2024
@pratap0007 pratap0007 changed the title [WIP] Remove creation of cluster task installersets Remove cluster task installersets Nov 7, 2024
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2024
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/cluster_task.go 39.1% 100.0% 60.9
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 47.9% 5.3

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/cluster_task.go 39.1% 100.0% 60.9
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 47.9% 5.3

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/cluster_task.go 39.1% 100.0% 60.9
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 47.9% 5.3

savitaashture
savitaashture reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pratap0007
You need to change these templates https://github.com/tektoncd/operator/blob/main/cmd/openshift/operator/kodata/tekton-addon/tekton-pipeline-template/pipeline_using_workspace.yaml#L25-L26 to use the resolverTasks now instead of ClusterTask

docs/TektonAddon.md Outdated Show resolved Hide resolved
docs/TektonAddon.md Show resolved Hide resolved
...penshift/manifests/bases/openshift-pipelines-operator-rh.clusterserviceversion.template.yaml Outdated Show resolved Hide resolved
pkg/apis/operator/v1alpha1/tektonaddon_default_test.go Show resolved Hide resolved
pkg/apis/operator/v1alpha1/tektonaddon_defaults.go Outdated Show resolved Hide resolved
pkg/apis/operator/v1alpha1/tektonaddon_defaults.go Show resolved Hide resolved
pkg/reconciler/openshift/tektonaddon/cluster_task.go Outdated Show resolved Hide resolved
hack/fetch-releases.sh
@@ -270,7 +270,7 @@ release_yaml_hub() {

fetch_openshift_addon_tasks() {
fetch_addon_task_script="${SCRIPT_DIR}/hack/openshift"
local dest_dir="cmd/openshift/operator/kodata/tekton-addon/addons/02-clustertasks/source_external"
local dest_dir="cmd/openshift/operator/kodata/tekton-addon/addons/02-tasks/source_external"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what will be there in this folder now ??

pkg/reconciler/openshift/tektonaddon/tektonaddon.go Outdated Show resolved Hide resolved
test/resources/tektonaddons.go Show resolved Hide resolved
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 11, 2024
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 56.1% 13.5

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 56.1% 13.5

@pratap0007
Copy link
Contributor Author

/retest

@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 56.1% 13.5

@pratap0007
Remove cluster task installersets
c8f03a1 
This patch will remove cluster task installersets and also
remove the existing cluster task installersets during operator upgrade

Signed-off-by: Shiv Verma <[email protected]>
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.5% 89.5% 2.0
pkg/reconciler/openshift/tektonaddon/transformer.go 42.6% 56.1% 13.5

@savitaashture
Copy link
Contributor

savitaashture commented Nov 14, 2024 •
edited
Loading

@pratap0007 You need to change these templates https://github.com/tektoncd/operator/blob/main/cmd/openshift/operator/kodata/tekton-addon/tekton-pipeline-template/pipeline_using_workspace.yaml#L25-L26 to use the resolverTasks now instead of ClusterTask

Use below sample format instead of clusterTask

apiVersion: tekton.dev/v1
kind: PipelineRun
metadata:
  name: kn-run
spec:
  pipelineSpec:
    tasks:
    - name: kn-run
      taskRef:
        resolver: cluster
        params:
        - name: kind
          value: task
        - name: name
          value: kn
        - name: namespace
          value: openshift-pipelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitaashture savitaashture savitaashture left review comments

@jkhelil jkhelil Awaiting requested review from jkhelil

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pratap0007 @tekton-robot @vdemeester @savitaashture