-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Update test_client.py for tests to run efficiently on tox. #8
Conversation
Signed-off-by: Shashank P <[email protected]>
Signed-off-by: Shashank P <[email protected]>
Signed-off-by: Shashank P <[email protected]>
Please add a description to this PR. |
Signed-off-by: Shashank P <[email protected]>
for more information, see https://pre-commit.ci
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
=======================================
Coverage ? 77.61%
=======================================
Files ? 3
Lines ? 487
Branches ? 106
=======================================
Hits ? 378
Misses ? 89
Partials ? 20 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shashank P <[email protected]>
Signed-off-by: Shashank P <[email protected]>
Signed-off-by: Shashank P <[email protected]>
Signed-off-by: Shashank P <[email protected]>
This is needed prior making it public release. Signed-off-by: Shashank P <[email protected]>
Signed-off-by: Shashank P <[email protected]>
Test Results (ubuntu)
|
Test Results (windows)
|
Test Results (macos)
|
Proposed changes
Updated tests to not to hang indefinitely in a loop.
Updated tests to achieve required coverage.
Addresses (#3)
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Addresses issue number