Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Update test_client.py for tests to run efficiently on tox. #8

Merged
merged 11 commits into from
Sep 10, 2024

Conversation

u625355
Copy link
Contributor

@u625355 u625355 commented Sep 10, 2024

Proposed changes

Updated tests to not to hang indefinitely in a loop.
Updated tests to achieve required coverage.

Addresses (#3)

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Functionality update (non-breaking change which updates or changes existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CI/CD update (an update to the CI/CD workflows, scripts, and/or configurations)
  • Documentation update (an update to enhance the user experience when reading through the docs)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have created (or updated) an Issue to track the status of this update/change and updated the link in this PR description (see above in the Proposed changes section) using the wording Addresses issue number
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

@nfelt14
Copy link
Collaborator

nfelt14 commented Sep 10, 2024

Please add a description to this PR.

@u625355 u625355 added the pre-commit.ci autofix Autofix trimming of extralines label Sep 10, 2024
@pre-commit-ci pre-commit-ci bot removed the pre-commit.ci autofix Autofix trimming of extralines label Sep 10, 2024
@u625355 u625355 added the pre-commit.ci autofix Autofix trimming of extralines label Sep 10, 2024
@pre-commit-ci pre-commit-ci bot removed the pre-commit.ci autofix Autofix trimming of extralines label Sep 10, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ u625355
❌ pre-commit-ci[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

tests/test_client.py Outdated Show resolved Hide resolved
tests/test_client.py Show resolved Hide resolved
tests/test_client.py Show resolved Hide resolved
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@a760e0b). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage        ?   77.61%           
=======================================
  Files           ?        3           
  Lines           ?      487           
  Branches        ?      106           
=======================================
  Hits            ?      378           
  Misses          ?       89           
  Partials        ?       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/test_client.py Outdated Show resolved Hide resolved
codecov.yml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
This is needed prior making it public release.

Signed-off-by: Shashank P <[email protected]>
tests/test_client.py Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Sep 10, 2024

Test Results (ubuntu)

path passed subtotal
tests/test_client.py 62 62
tests/test_helpers.py 1 1
TOTAL 63 63

Link to workflow run

Copy link

github-actions bot commented Sep 10, 2024

Test Results (windows)

path passed subtotal
tests\test_client.py 62 62
tests\test_helpers.py 1 1
TOTAL 63 63

Link to workflow run

Copy link

github-actions bot commented Sep 10, 2024

Test Results (macos)

path passed subtotal
tests/test_client.py 62 62
tests/test_helpers.py 1 1
TOTAL 63 63

Link to workflow run

@nfelt14 nfelt14 merged commit 41cb7ec into tektronix:main Sep 10, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants