feat: Added Full python API support for MDO3 model. #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfelt14
requested changes
Nov 12, 2024
| @@ -26,6 +26,7 @@ Things to be included in the next release go here. | |||
| - Added the `get_errors()` method to the `Device` class to enable easy access to the current error code and messages on any device. | |||
| - Added more details to the Architectural Overview page of the documentation as well as highlighting to the device driver diagram on the page. | |||
| - Added regex matching to the `verify_values()` helper function to allow for more flexible value verification. | |||
| - Full Python API support for MDO3 model. | |||
There was a problem hiding this comment.
Suggested change
| - Full Python API support for MDO3 model. | |
| - Full Python API support for the MDO3 model. |
| Commands and Queries: | ||
| ``` | ||
| - MARK {NEXT|PREVious} | ||
| - MARK:CREATE {CH<x>|MATH|REF1|REF2|REF3|REF4|B1|B2|B3|B4|REF1|REF2|REF3|REF4|DIGital|COLUMN|RF_AMPlitude|RF_FREQuency|RF_PHASe} |
There was a problem hiding this comment.
Why does this have create but not delete?
| Commands and Queries: | ||
| ``` | ||
| - MARK {NEXT|PREVious} | ||
| - MARK:DELEte {CH<x>|MATH|REF1|REF2|REF3|REF4|B1|B2|B3|B4|REF1|REF2|REF3|REF4|DIGital|COLUMN|SELECTED|ALL||RF_AMPlitude|RF_FREQuency|RF_PHASe} |
There was a problem hiding this comment.
Why does this have delete but not create?
| phase measurement. This is equivalent to setting the 'To:' waveform in the 'Measure | ||
| Delay' side menu or the 'Measure Phase' side menu. Measurements are specified by <x>, | ||
| which ranges from 1 to 8. | ||
| 'from'. This is equivalent to setting the 'From:' waveform in the 'Measure Delay' |
There was a problem hiding this comment.
Why the extra whitespace? This probably happened in more than one place.
| @@ -1117,42 +1078,6 @@ def polarity(self) -> SearchSearchItemTriggerATimeoutPolarity: | |||
| """ | |||
| return self._polarity | |||
|
|
|||
| @property | |||
| def source(self) -> SearchSearchItemTriggerATimeoutSource: | |||
| """Return the ``SEARCH:SEARCH<x>:TRIGger:A:TIMEOut:SOUrce`` command. | |||
There was a problem hiding this comment.
What happened to this command?
There was a problem hiding this comment.
This command is available in MDO, MSO, LPDMSO and TekscopePC.
There was a problem hiding this comment.
So why was it removed from here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Please include a summary of the changes and any links to related issues. Please also include relevant motivation and context.
Addresses #< fill in issue number here >
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Addresses #<issue_number>