Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Linking Issue for Non-VISA Executables #32

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Conversation

esarver
Copy link
Member

@esarver esarver commented Sep 17, 2024

The cargo resolver will automatically unify features when running cargo build --workspace, so we need to make sure that we build VISA-enabled and
VISA-disabled packages separately.

The cargo resolver will automatically unify features
when running `cargo build --workspace`, so we need
to make sure that we build VISA-enabled and
VISA-disabled packages separately.
@esarver esarver self-assigned this Sep 17, 2024
@esarver esarver requested a review from a team as a code owner September 17, 2024 16:38
Copy link

github-actions bot commented Sep 17, 2024

Code Coverage

Package Line Rate Health
kic-discover-visa/src/ethernet/mod.rs 0%
kic-discover/src/lib.rs 0%
kic/src/main.rs 0%
kic-visa/src/error.rs 0%
kic-discover/src/instrument_discovery/mod.rs 0%
kic-discover-visa/src/main.rs 0%
kic-visa/src/process.rs 0%
instrument-repl/src/resources/mod.rs 100%
kic-discover-visa/src/instrument_discovery/mod.rs 0%
instrument-repl/src/instrument.rs 86%
kic-discover/src/usbtmc/mod.rs 0%
kic-discover/src/ethernet/mod.rs 0%
instrument-repl/src/state_machine.rs 63%
kic-discover-visa/src/lib.rs 0%
kic-discover-visa/src/usbtmc/mod.rs 0%
kic/src/process.rs 0%
instrument-repl/src/tsp_error.rs 0%
kic-visa/src/main.rs 0%
instrument-repl/src/error.rs 0%
kic-discover/src/main.rs 0%
kic-discover-visa/src/visa.rs 0%
instrument-repl/src/repl.rs 0%
kic-discover/src/process.rs 0%
kic/src/error.rs 0%
Summary 10% (295 / 2839)

@esarver
Copy link
Member Author

esarver commented Sep 17, 2024

Merging without review for critical fix. Fix was trivial.

@esarver esarver merged commit e2e837a into main Sep 17, 2024
11 checks passed
@esarver esarver deleted the bug/fix-visa-linking branch September 17, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant