Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get TCPIP VISA Instrument Info from LXI ID Page Instead of *IDN? #44

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

esarver
Copy link
Member

@esarver esarver commented Nov 14, 2024

This is a less disruptive way to get the Instrument information since it gets this information from the webpage instead of from the command processor on the instrument.

Testing: This has been tested using NI VISA and a Keithley Model 2461

This is the first and probably worst option for getting
instrument information from VISA in discovery.
This is a less disruptive way to get the Instrument information since it
gets this information from the webpage instead of from the command
processor on the instrument.

Testing: This has been tested using NI VISA and a Keithley Model 2461
@esarver esarver self-assigned this Nov 14, 2024
@esarver esarver requested a review from a team as a code owner November 14, 2024 14:16
Copy link

github-actions bot commented Nov 14, 2024

Code Coverage

Package Line Rate Health
kic-discover-visa/src/ethernet/mod.rs 0%
kic-discover/src/lib.rs 0%
kic/src/main.rs 0%
kic-discover/src/instrument_discovery/mod.rs 0%
kic-discover-visa/src/main.rs 0%
kic-visa/src/process.rs 0%
instrument-repl/src/resources/mod.rs 100%
kic-discover-visa/src/instrument_discovery/mod.rs 0%
instrument-repl/src/instrument.rs 86%
kic-discover/src/ethernet/mod.rs 0%
instrument-repl/src/state_machine.rs 63%
kic-discover-visa/src/lib.rs 0%
kic/src/process.rs 0%
instrument-repl/src/tsp_error.rs 0%
kic-visa/src/main.rs 0%
kic-discover/src/main.rs 0%
kic-discover-visa/src/visa.rs 0%
instrument-repl/src/repl.rs 0%
kic-discover/src/process.rs 0%
Summary 11% (295 / 2638)

@esarver esarver merged commit 308dfb0 into main Nov 14, 2024
16 checks passed
@esarver esarver deleted the bug/discover-visa-reset branch November 14, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants