Support for plugable reconcilers #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-strusiewiczsurmacki-mobica
requested review from
MaxRink,
Cellebyte,
chdxD1 and
schrej
as code owners
schrej
reviewed
Apr 22, 2024
pkg/reconciler/reconciler.go
Outdated
| type Reconciler struct { | ||
| client client.Client | ||
| logger logr.Logger | ||
| iReconciler IReconciler |
There was a problem hiding this comment.
A little confusing that both are called reconciler imo, maybe something like 'adapter' would be better here, similar to the generic ipam reconciler. But I'll leave it up to you.
There was a problem hiding this comment.
Done
p-strusiewiczsurmacki-mobica
force-pushed
the
config-interface
branch
2 times, most recently
from
d6058fd
to
b9e2434
Compare
schrej
requested changes
May 22, 2024
p-strusiewiczsurmacki-mobica
force-pushed
the
config-interface
branch
from
b9e2434
to
5848ec8
Compare
schrej
approved these changes
May 23, 2024
This was referenced May 29, 2024
Signed-off-by: Patryk Strusiewicz-Surmacki <[email protected]>
p-strusiewiczsurmacki-mobica
force-pushed
the
config-interface
branch
from
5848ec8
to
a18e452
Compare
|
Closing this as it will be addressed in #124 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces basic support for plugable reconcilers as it will be required by #99.
LegacyReconcilerthat uses netlink/FRR was separated from theReconcilerstruct and is provided to this struct byIReconcilerinterface, via dependency injection. Additionally stub for NETCONF based reconciler was created and config flag for selection was added.