Fix DNS server panic on darwin based systems. #3474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
The DNS server didn't protect several of its variables that were used concurrently by different go-routines. This commit also replaces an untyped `sync.Map` with a typed `xsync.MapOf` Signed-off-by: Thomas Hallgren <[email protected]>
A darwin machine with full access to the cluster's subnet never creates a TUN-device, so a check is needed if the device actually exists when setting DNS (which is a noop anyway on darwin). Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
force-pushed
the
thallgren/darwin-dns-panic
branch
from
0a6a004 to
b83d8fb
Compare
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A darwin machine with full access to the cluster's subnet never creates
a TUN-device, so a check is needed if the device actually exists when
setting DNS (which is a noop anyway on darwin).