Fix panic when allowing conflicting subnets on macOS. #3785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thallgren
force-pushed
the
thallgren/v2.21.3
branch
from
32a9dec to
58f8ae7
Compare
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
This commit fixes a regression introduced in 2.21.0, causing the macOS client to panic when the `--allow-conflicting-subnets` connect flag was used, or when `routing.allowConflictingSubnets` was added to the client configuration. Closes #3784 Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
force-pushed
the
thallgren/v2.21.3
branch
from
58f8ae7 to
e02463a
Compare
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
njayp
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a regression introduced in 2.21.0, causing the macOS
client to panic when the
--allow-conflicting-subnetsconnect flag wasused, or when
routing.allowConflictingSubnetswas added to the clientconfiguration.
Closes #3784