Using the --proxy-via flag would sometimes cause connection timeouts. #3786
+138
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
thallgren
force-pushed
the
thallgren/proxy-via-multi-wf
branch
2 times, most recently
from
84b327a to
92133b4
Compare
Typically, a `telepresence connect --proxy-via <subnet>=<workflow>` would fail with a "deadline exceeded" message when several workloads were present in the namespace, the one targeted by the proxy-via didn't yet have an agent installed, and other workloads had an agent. This was due to a race condition in the logic for the agent-based port-forwards in the root daemon. The conditions causing this race are now eliminated. Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
force-pushed
the
thallgren/proxy-via-multi-wf
branch
from
92133b4 to
1f733e7
Compare
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
force-pushed
the
thallgren/proxy-via-multi-wf
branch
from
8ecec22 to
0566da4
Compare
thallgren
added
the
ok to test
github-actions
bot
removed
the
ok to test
P0lip
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically, a
telepresence connect --proxy-via <subnet>=<workflow>would fail with a "deadline exceeded" message when several workloads
were present in the namespace, the one targeted by the proxy-via didn't
yet have an agent installed, and other workloads had an agent. This was
due to a race condition in the logic for the agent-based port-forwards
in the root daemon. The conditions causing this race are now eliminated.