Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin that finds visible empty methods #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Plugin that finds visible empty methods #11

wants to merge 3 commits into from

Conversation

dogfuntom
Copy link

Hi, I created a plugin. It's not very interesting, but I find it useful, and it should be useful at least for other advanced Unity programmers like me. I hope it's welcome in your repository.

@atdimitrov
Copy link
Contributor

Hi @dogfuntom,

We've tested your plugin and we've found some problems:

  1. It doesn't work for assemblies compiled in debug, because of the nop instructions.
  2. When assembly is reloaded, because the file in the file system has been changed, the plugin window doesn't refresh and shows invalid results.
  3. It doesn't search in nested types, if is not used explicitly on the nested type itself.
  4. Inconsistent result output - the plugin doesn't show the methods with the internal access modifier, but shows methods with all other access modifiers, incl. private and protected internal.
  5. It doesn't show virtual methods for some strange reason.

It would be very nice, if you fix these problems.

@atdimitrov atdimitrov closed this Mar 7, 2016
@atdimitrov atdimitrov reopened this Mar 7, 2016
@dogfuntom
Copy link
Author

Thanks for your feedback, I didn't even remotely think about half of this cases to test. I shall fix these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants