Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Trivy action #247

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Trivy action #247

wants to merge 1 commit into from

Conversation

jackdawm
Copy link
Contributor

@jackdawm jackdawm commented Nov 1, 2024

What was changed

Upgrade the codeql upload action to v3 and have it always run, even in a non-0 exit state.

Why?

This reporting seems to have been broken for 2 years, and I would like to see if the if: always() helps.

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@jackdawm jackdawm requested review from a team as code owners November 1, 2024 16:22
@jackdawm
Copy link
Contributor Author

jackdawm commented Nov 1, 2024

Making a note that I have to update this to pull from a different image, and I should clone the public ghcr.io image to our ghcr.io repo in a different action like I did for Semgrep. Otherwise, if you look at the action for this, you'll notice it gets a rate limit error (as expected from aquasecurity/trivy-action#389)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants