Port previous NewTestLogger flags over #7432
Conversation
stephanos
force-pushed
the
support-TEMPORAL_TEST_LOG_FORMAT
branch
4 times, most recently
from
3f2149b to
ea29fc2
Compare
| func WithoutCaller() LoggerOption { | ||
| return func(t *TestLogger) { | ||
| t.state.logCaller = false | ||
| } | ||
| } | ||
|
|
||
| func LogCaller() LoggerOption { | ||
| return func(t *TestLogger) { | ||
| t.state.logCaller = false | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This doesn't work together with log.BuildZapLogger which defaults to disabling this. Removing it for now.
| @@ -55,13 +56,13 @@ var _ Logger = (*zapLogger)(nil) | |||
|
|
|||
| // NewTestLogger returns a logger for tests | |||
| func NewTestLogger() *zapLogger { | |||
There was a problem hiding this comment.
There's a ticket to remove this function and replace it with testlogger.TestLogger.
stephanos
force-pushed
the
support-TEMPORAL_TEST_LOG_FORMAT
branch
from
ea29fc2 to
1269009
Compare
stephanos
changed the title
stephanos
changed the title
| if format == "" { | ||
| format = "console" | ||
| } | ||
|
|
||
| logger := BuildZapLogger(Config{ | ||
| Level: os.Getenv(testLogLevelEnvVar), | ||
| Level: os.Getenv(TestLogLevelEnvVar), | ||
| Format: format, | ||
| Development: true, |
There was a problem hiding this comment.
should we port this too? it looks like it controls whether it panics on dpanic
There was a problem hiding this comment.
The new TestLogger already has a flag panicOnDPanic which by default is true.
There was a problem hiding this comment.
Why do we need envs to control test logger? Do we use it anywhere?
There was a problem hiding this comment.
David does to switch it to JSON format; and I noticed that I actually set up my IDE to log on error level instead of debug level. So that's two use cases already.
What changed?
Ports
TEMPORAL_TEST_LOG_FORMATandTEMPORAL_TEST_LOG_LEVELto testlogger.TestLogger.Why?
To not break developer setups.
How did you test it?
Potential risks
Documentation
Is hotfix candidate?