Use assertion function #7433
Draft
Use assertion function #7433
+49
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
force-pushed
the
priority-assert
branch
from
afbac2f to
f304fa0
Compare
dnr
reviewed
Mar 6, 2025
| @@ -178,7 +183,7 @@ func (tm *priTaskMatcher) forwardTasks(lim quotas.RateLimiter, retrier backoff.R | |||
| if res.ctxErr != nil { | |||
| return // task queue closing | |||
| } | |||
| bugIf(res.task == nil, "bug: bad match result in forwardTasks") | |||
| softassert.That(tm.logger, res.task != nil, "expected a task from match") | |||
There was a problem hiding this comment.
this should continue or return on failure, otherwise it'll just panic immediately
| @@ -247,11 +252,13 @@ func (tm *priTaskMatcher) validateTasksOnRoot(lim quotas.RateLimiter, retrier ba | |||
| if res.ctxErr != nil { | |||
| return // task queue closing | |||
| } | |||
| bugIf(res.task == nil, "bug: bad match result in validateTasksOnRoot") | |||
| softassert.That(tm.logger, res.task != nil, "expected a task from match") | |||
| @@ -276,7 +283,7 @@ func (tm *priTaskMatcher) forwardPolls() { | |||
| if res.ctxErr != nil { | |||
| return // task queue closing | |||
| } | |||
| bugIf(res.poller == nil, "bug: bad match result in forwardPolls") | |||
| softassert.That(tm.logger, res.poller != nil, "expected a poller from match") | |||
| @@ -324,7 +331,7 @@ func (tm *priTaskMatcher) forwardPolls() { | |||
| func (tm *priTaskMatcher) Offer(ctx context.Context, task *internalTask) (bool, error) { | |||
| finish := func() (bool, error) { | |||
| res, ok := task.getResponse() | |||
| bugIf(!ok, "Offer must be given a sync match task") | |||
| softassert.That(tm.logger, ok, "expected a sync match task") | |||
| @@ -410,7 +414,7 @@ func (tr *priTaskReader) signalNewTasks(resp subqueueCreateTasksResponse) { | |||
| // adding these tasks to outstandingTasks. So they should definitely not be there. | |||
| for _, t := range resp.tasks { | |||
| _, found := tr.outstandingTasks.Get(t.TaskId) | |||
| bugIf(found, "bug: newly-written task already present in outstanding tasks") | |||
| softassert.That(tr.logger, !found, "newly-written task already present in outstanding tasks") | |||
There was a problem hiding this comment.
this should probably do a slices.DeleteFunc and remove the ones that are found
Comment on lines
+452
to
+453
| softassert.That(tr.logger, found, "completed task not found in oustandingTasks") | ||
| softassert.That(tr.logger, !wasAlreadyAcked.(bool), "completed task was already acked") |
There was a problem hiding this comment.
probably just return if either of these are true?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Documentation
Is hotfix candidate?