Do not use reduce_sum before returning to loss wrapper. #2058
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief Description of the PR:
Handle reduction with loss wrapper not with this function.
Currently when using
tfa.losses.SigmoidFocalCrossEntropy(reduction: str = tf.keras.losses.Reduction.NONE)
, the loss is still reduced by summing over the last axis. I would expecttfa.losses.SigmoidFocalCrossEntropy(reduction: str = tf.keras.losses.Reduction.NONE)
to return a loss of the same shape asy_pred
which is currently not the case.Type of change
Checklist:
How Has This Been Tested?
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes:
*