Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crf_decode: fix broken type annotation #2694

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

exyi
Copy link

@exyi exyi commented Apr 15, 2022

Description

crf_decode returns a tuple of decode_tags, best_score, but the type annotation suggests that it returns only one tensor

Type of change

  • Bug fix

@boring-cyborg boring-cyborg bot added the text label Apr 15, 2022
@google-cla
Copy link

google-cla bot commented Apr 15, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@bot-of-gabrieldemarmiesse

@howl-anderson

You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

Copy link

@vulkomilev vulkomilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

@bhack
Copy link
Contributor

bhack commented Aug 26, 2022

@exyi You need to sign the CLA

@exyi
Copy link
Author

exyi commented Aug 28, 2022

It's not possible, I'm a robot.

@bhack bhack requested a review from seanpmorgan August 28, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants