Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
NA
Problem description
We currently create bespoke sfpu insns using .word, that has 2 shortcomings
We can't use
.insn
because spu insns do not use the regular riscv encoding, so its length checking goes wrong.What's changed
Added
.ttinsn
to the assembler. This will do the swizzling, and arrange for them to be disassemblable.Alter the ckernel_ops.h header appropriately (although this is machine-generated the generator is unavailable)
There are other instances of the ckernel_ops.h headers in submodules, that will also need updating.
This makes disassembling kernels much more pleasant. See SFPI release notes for example (https://github.com/tenstorrent/sfpi/releases/tag/v6.2.0)
Checklist