Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand s3 client options #862

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Expand s3 client options #862

merged 4 commits into from
Oct 31, 2023

Conversation

lesleydreyer
Copy link
Contributor

@lesleydreyer lesleydreyer commented Oct 31, 2023 •
edited
Loading

small create S3 client changes

  • Add types to httpOptions
  • Previously httpOptions would be ignored if not sslEnabled so changed to use if they are passed in
  • Converted maxRetries to maxAttempts to sync terafoundation config_schema with s3 changes from s3 v2 -> s 3v3
  • Allowed a few more s3 options for the http handler to pass through just in case ever needed

jsnoble
jsnoble approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@jsnoble jsnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnoble jsnoble merged commit fec34b3 into master Oct 31, 2023
4 checks passed
@jsnoble jsnoble deleted the expand-s3-client-options branch October 31, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnoble jsnoble jsnoble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lesleydreyer @jsnoble