Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[teraslice] Fix teraslice k8s --dev mode process exit bug #3758

Merged
merged 4 commits into from
Sep 18, 2024
Merged

[teraslice] Fix teraslice k8s --dev mode process exit bug #3758

merged 4 commits into from
Sep 18, 2024

Conversation

sotojn
Copy link
Contributor

@sotojn sotojn commented Sep 18, 2024 •
edited
Loading

This PR makes the following changes:

Bug fixes

  • Fixes bug when running ts-scripts k8s where the master, execution contoller, and workers don't properly run their respective exit processes.

Ref to issue #3738

@sotojn sotojn self-assigned this Sep 18, 2024
@sotojn sotojn marked this pull request as ready for review September 18, 2024 16:06
busma13
busma13 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@busma13 busma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we need to bump teraslice, or sneak this in with another release?

@godber godber merged commit 500a005 into master Sep 18, 2024
67 checks passed
@godber godber deleted the fix-dev-option-worker-exit-bug branch September 18, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godber godber godber approved these changes

@busma13 busma13 busma13 approved these changes

Assignees

@sotojn sotojn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sotojn @godber @busma13