[job-components, scripts, terafoundation, teraslice-cli, teraslice-client-js, teraslice-messaging, utils, xlucene-parser] fix implicit any index typescript errors #3789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busma13
force-pushed
the
update-typescript
branch
from
766e773
to
4a1ac09
Compare
jsnoble
reviewed
Oct 8, 2024
jsnoble
reviewed
Oct 8, 2024
jsnoble
reviewed
Oct 8, 2024
jsnoble
reviewed
Oct 8, 2024
jsnoble
reviewed
Oct 8, 2024
jsnoble
reviewed
Oct 8, 2024
jsnoble
reviewed
Oct 8, 2024
jsnoble
reviewed
Oct 8, 2024
jsnoble
reviewed
Oct 8, 2024
jsnoble
reviewed
Oct 8, 2024
busma13
force-pushed
the
update-typescript
branch
from
1c8b870
to
cbae5fc
Compare
busma13
commented
Oct 17, 2024
Comment on lines
+36
to
+42
| /** | ||
| * Verify that k is a key of object O | ||
| */ | ||
| export function isKey<T extends object>(O: T, k: PropertyKey): k is keyof T { | ||
| return k in O; | ||
| } | ||
|
|
There was a problem hiding this comment.
I removed the getKeys function used in earlier commits in favor of isKey. getKeys used type assertion, so could be unsafe. isKey just returns a boolean and narrows the type for us.
bump: (patch) [email protected], [email protected] bump: (patch) [email protected], @terascope/[email protected] bump: (patch) @terascope/[email protected], @terascope/[email protected] bump: (patch) @terascope/[email protected], [email protected] bump: (patch) [email protected], [email protected]
busma13
force-pushed
the
update-typescript
branch
from
4554ca8
to
eb74a0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In typescript 5.5 the
suppressImplicitAnyIndexErrorsrule will be removed. This PR fixes all ignored errors of this type in the following packages in preparation for the move to version 5.5 or above:suppressImplicitAnyIndexErrorsis set to true in the tsconfig of all updated packages so we don't introduce any more of these errors before the rule is removed at the root level.Todo: bump packages
Packages that still have these errors:
ref: #3772