fix: Add a way to prevent cloudwatch log group from being created #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-spinergie
changed the title
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Not stale. |
|
For anyone stumbling onto this issue, don't forget that you can manually edit the module on your computer to add the changes from this PR. It won't be definitive but at least it lets us move on short term. |
antonbabenko
approved these changes
Nov 28, 2024
antonbabenko
pushed a commit
that referenced
this pull request
Nov 28, 2024
|
This PR is included in version 5.2.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115
Fixes #121
Description
Do not create cloudwatch log group if
stage_access_log_settings == null.Motivation and Context
See #115 & #121
Before this PR, it wasn't possible to prevent cloudwatch log group creation.
Breaking Changes
This is not a breaking change.
How Has This Been Tested?
Before this PR, setting
stage_access_log_settings = nullwould result in a failing config so it's not possible to test before the change.With the change, I was able to deploy my own config properly. (And omit the cloudwatch log group creation)