Implement TraceFunctionCall; replace Tracef #146
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the TraceFunctionCall function in 'utils.go'. All 'log.Tracef()' calls in foreman/api were replaced by the new trace function. Refs terraform-coop#138 terraform-coop#138 (comment) Signed-off-by: Dominik Pataky <[email protected]>
Both functions wrap the log.* functions, adding the filename and line number of the calling function. Uses a switch to determine the final log.* function that is called. jobtemplate and template_input were refactored to use 'Debugf' instead of 'Debug'. For testing, domain.go was also refactored to use utils.* instead of log.*. Signed-off-by: Dominik Pataky <[email protected]>
Signed-off-by: Dominik Pataky <[email protected]>
Also removes the dependency on HanseMerkur/terraform-provider-utils/log in many files. Signed-off-by: Dominik Pataky <[email protected]>
Completes the refactoring from log.* to utils.* for better debugging output during provider runtime. Signed-off-by: Dominik Pataky <[email protected]>
|
Refactoring is complete. All This allows for a better debug output for users which have no code editor or debuggers at hand. During the refactoring I also fixed some other small issues like typos, formatting or flows. Nothing regarding any logic was changed though, so no user-side changes or errors are to be expected. |
lhw
approved these changes
Jan 4, 2024
|
This merge didn't work, will look into it later this week. It's mainly cosmetic refactoring, so no new features are blocked for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the TraceFunctionCall function in 'utils.go'.
All 'log.Tracef()' calls are replaced with the new function.
Refs #138
See: #138 (comment)