Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(main): unmark endpoint as sensitive #2249

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

wyardley
Copy link
Contributor

It doesn't appear there's any clear reason that the endpoint output needs to be sensitive.
Fixes #2248

@wyardley wyardley requested review from apeabody, ericyz and a team as code owners January 21, 2025 20:51
It doesn't appear there's any clear reason that the `endpoint` output
needs to be sensitive.
Fixes terraform-google-modules#2248
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody self-assigned this Jan 21, 2025
@wyardley
Copy link
Contributor Author

@apeabody may have missed some, but took a first pass at updating tests.

Do you have any more context on why it may have been set this way originally?

@apeabody
Copy link
Collaborator

@apeabody may have missed some, but took a first pass at updating tests.

Do you have any more context on why it may have been set this way originally?

Hi @wyardley - I do no know, but it appears it has been this way since at least early 2019. I'm checking with the broader team if there is a reason not to change. Cheers!

@apeabody
Copy link
Collaborator

/gcbrun

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @wyardley!

Agreed - sensitive is primarily needed for passwords, tokens, and private certs.

@apeabody
Copy link
Collaborator

/gcbrun

@wyardley
Copy link
Contributor Author

Agreed - sensitive is primarily needed for passwords, tokens, and private certs.

I thought maybe at some point, some variant of the endpoint had contained a secret maybe, but that doesn't seem super likely? I found the same thing that you did -- even digging through changes of filenames etc, it was hard to figure out in the git history why it was set this way. Thanks for quick review 🙏

@apeabody apeabody enabled auto-merge (squash) January 22, 2025 19:40
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody apeabody merged commit 2566fec into terraform-google-modules:main Jan 22, 2025
4 checks passed
@wyardley wyardley deleted the wyardley/2248 branch January 22, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

endpoint output unnecessarily sensitive
2 participants