-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(main): unmark endpoint
as sensitive
#2249
fix(main): unmark endpoint
as sensitive
#2249
Conversation
It doesn't appear there's any clear reason that the `endpoint` output needs to be sensitive. Fixes terraform-google-modules#2248
5724b41
to
22057f6
Compare
/gcbrun |
@apeabody may have missed some, but took a first pass at updating tests. Do you have any more context on why it may have been set this way originally? |
Hi @wyardley - I do no know, but it appears it has been this way since at least early 2019. I'm checking with the broader team if there is a reason not to change. Cheers! |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @wyardley!
Agreed - sensitive
is primarily needed for passwords, tokens, and private certs.
/gcbrun |
I thought maybe at some point, some variant of the endpoint had contained a secret maybe, but that doesn't seem super likely? I found the same thing that you did -- even digging through changes of filenames etc, it was hard to figure out in the git history why it was set this way. Thanks for quick review 🙏 |
/gcbrun |
It doesn't appear there's any clear reason that the
endpoint
output needs to be sensitive.Fixes #2248