feat: create service account as part of instance template module #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
q2w
changed the title
bharathkkb
reviewed
Jan 23, 2025
| description = "Create a new service account to attach to the instance. This is alternate to providing the service_account input variable." | ||
| default = { | ||
| enabled = true | ||
| scopes = ["cloud-platform"] |
There was a problem hiding this comment.
It's generally not needed to use scope. For this functiality I would recommend changing logic to just use cloud-platform internally if create is true.
| default = null | ||
| } | ||
|
|
||
| variable "create_new_service_account" { |
There was a problem hiding this comment.
nit: lets name as create_service_account
Comment on lines
+24
to
+55
| variable "region" { | ||
| description = "The GCP region to create and test resources in" | ||
| type = string | ||
| default = "us-central1" | ||
| } | ||
|
|
||
| variable "subnetwork" { | ||
| description = "The name of the subnetwork create this instance in." | ||
| default = "" | ||
| } | ||
|
|
||
| variable "tags" { | ||
| type = list(string) | ||
| description = "Network tags, provided as a list" | ||
| } | ||
|
|
||
| variable "labels" { | ||
| type = map(string) | ||
| description = "Labels, provided as a map" | ||
| } | ||
|
|
||
| variable "enable_nested_virtualization" { | ||
| type = bool | ||
| description = "Defines whether the instance should have nested virtualization enabled." | ||
| default = false | ||
| } | ||
|
|
||
| variable "threads_per_core" { | ||
| type = string | ||
| description = "The number of threads per physical core. To disable simultaneous multithreading (SMT) set this to 1." | ||
| default = null | ||
| } |
There was a problem hiding this comment.
Lets hard code all of these in the example
| @@ -0,0 +1,47 @@ | |||
| /** | |||
| * Copyright 2019 Google LLC | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.