Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init commit #6

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

init commit #6

wants to merge 40 commits into from
+6,517 −319

Conversation

Khuzaima05
Copy link
Member

@Khuzaima05 Khuzaima05 commented Nov 15, 2024 •
edited
Loading

Description

Migrating ESO to Public

issue: https://github.ibm.com/orgs/GoldenEye/projects/3/views/1?filterQuery=assignee%3A%40me&pane=issue&itemId=677569

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Khuzaima05
Copy link
Member Author

/run pipeline

ocofaigh
ocofaigh reviewed Nov 28, 2024
View reviewed changes
main.tf Outdated Show resolved Hide resolved
ocofaigh
ocofaigh reviewed Nov 28, 2024
View reviewed changes
main.tf Show resolved Hide resolved
ocofaigh
ocofaigh reviewed Nov 28, 2024
View reviewed changes
main.tf Outdated Show resolved Hide resolved
@imprateeksh
Copy link
Member

@Khuzaima05 - Please update this PR with the latest changes.

@Khuzaima05 Khuzaima05 marked this pull request as ready for review January 13, 2025 09:30
@Khuzaima05 Khuzaima05 self-assigned this Jan 13, 2025
@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05 Khuzaima05 requested a review from vbontempi January 15, 2025 08:17
@Khuzaima05
Copy link
Member Author

/run pipeline

1 similar comment
@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

ocofaigh
ocofaigh requested changes Feb 4, 2025
View reviewed changes
Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few more housekeeping comments

.github/settings.yml Outdated Show resolved Hide resolved
.mdlrc Outdated Show resolved Hide resolved
.cra/.fileignore Outdated Show resolved Hide resolved
.whitesource Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
ocofaigh
ocofaigh reviewed Feb 4, 2025
View reviewed changes
renovate.json Show resolved Hide resolved
ocofaigh
ocofaigh reviewed Feb 5, 2025
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
ocofaigh
ocofaigh reviewed Feb 5, 2025
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
@vbontempi
Copy link
Member

/run pipeline

@vbontempi
Copy link
Member

/run pipeline

@vbontempi
Copy link
Member

@ocofaigh I addressed comments, could you please review again?
@Khuzaima05 the issue with the certificate is fixed, it will be fixed with the common-dev update performed by CI or you could force it

@vbontempi vbontempi requested a review from ocofaigh February 6, 2025 19:48
@vbontempi
Copy link
Member

/run pipeline

@vbontempi
Copy link
Member

@Khuzaima05 please check also if the couple image tag - hash are correct in the default values

@Khuzaima05
Copy link
Member Author

@Khuzaima05 please check also if the couple image tag - hash are correct in the default values
Checking that!!

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbontempi vbontempi vbontempi requested changes

@ocofaigh ocofaigh Awaiting requested review from ocofaigh ocofaigh is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@Khuzaima05 Khuzaima05

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Khuzaima05 @imprateeksh @vbontempi @ocofaigh