Embed default config and attempt to fix tests #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AlexMikhalev <[email protected]>
Signed-off-by: AlexMikhalev <[email protected]>
AlexMikhalev
commented
Jan 31, 2024
| if filename.exists() { | ||
| log::warn!("File exists"); | ||
| log::warn!("{:?}", filename); | ||
| } else { | ||
| log::warn!("File does not exist"); | ||
| std::fs::copy("default/settings.toml", &filename)?; | ||
| // FIXME: the logic of settings that each app - desktop or server have their own default settings.toml |
There was a problem hiding this comment.
@mre I want your opinion on how to design it better - see FIXME: comment.
There was a problem hiding this comment.
I think we could have an environment variable for the config path that could be overwritten.
Then we could use it here.
TERRAPHIM_CONFIG_PATH=...It could be set to a sane default.
Just an idea.
There was a problem hiding this comment.
What is the path variable for default cargo run and cargo test? We can put the default config into that path, and it will pick it up automatically for run and test, but then subfolders in the Axum server and desktop can have their own when run.
mre
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests are running using earthly +pipeline on earthly satellite.
Strangely, create article API tests are failing - the server can't add articles to the index.
I also changed default config - as a quick fix, we need to think how to make it in a sane way.