Preserve FTBQ quest icon background shape choices #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In convertFtbQuests.ts: - Expands `QuestShape` type def. to include default FTBQ shape options. - Converts all those default FTBQ shape options to string to specify where to find matching textures.. In HeraclesQuest.ts: - Changes `HeraclesQuest` type's `icon_background?` element to be type `string` Note: Heracles currently ships with only two shapes; this patch is concerened only with Odysseus. It seemed better to preserve this information than to task a user with mapping the choices from FTQB chapter files to edits in corresponding multiple Heracles quest files.
MsRandom
requested changes
Nov 4, 2023
MsRandom
reviewed
Nov 4, 2023
sisby-folk
reviewed
Nov 4, 2023
MsRandom
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In convertFtbQuests.ts:
QuestShapetype def. to include default FTBQ shape options.In HeraclesQuest.ts:
HeraclesQuesttype'sicon_background?element to be typestringNote: Heracles currently ships with only two shapes; this patch is concerened only with Odysseus. It seemed better to preserve this information than to task a user with mapping the choices from FTQB chapter files to edits in corresponding multiple Heracles quest files.