d2target: add support for box arrowheads #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamratson
commented
Dec 18, 2024
adamratson
commented
Dec 18, 2024
alixander
requested changes
Dec 29, 2024
There was a problem hiding this comment.
Thanks @adamratson ! Sorry for the late review, hope you had a good holiday season.
The math doesn't seem to account for stroke width values. e.g. see circle here vs the boxes that overlap
|
Can this be completed in time for the next release? Thanks. |
|
hi @adamratson let me know if you are still interested in pursuing this, thanks! |
alixander
force-pushed
the
box-arrowheads
branch
from
a412f39 to
a6da9bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for box arrowheads in d2target and d2sketch
Fixes #2227
I've updated tests where I've seen I should do so - please let me know if I've missed any!!
Pic:
Please let me know if I've missed anything - first time contributor so good chance I have!
I'll try and act on feedback over the week :)