-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to React 17 #2329
Update to React 17 #2329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me so far, but please have a look at the commit messages, they must match the semantic-release-plugin conventions.
src/Container/AddWmsPanel/AddWmsLayerEntry/AddWmsLayerEntry.spec.tsx
Outdated
Show resolved
Hide resolved
src/Slider/LayerTransparencySlider/LayerTransparencySlider.example.md
Outdated
Show resolved
Hide resolved
src/Container/AddWmsPanel/AddWmsLayerEntry/AddWmsLayerEntry.spec.tsx
Outdated
Show resolved
Hide resolved
src/Container/AddWmsPanel/AddWmsLayerEntry/AddWmsLayerEntry.tsx
Outdated
Show resolved
Hide resolved
Reminder: The commit messages should be reformatted to meet the semantic-release prerequisites. |
7a73f9d
to
1f75122
Compare
…onents to become compatible with it as well BREAKING CHANGE: This updates the peerDependency of React to version 17
1f75122
to
5b9075e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @Unraveler!
🎉 This PR is included in version 16.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
DEPENDENCY UPDATE
Description:
This PR changes previous peer dependencies making the package now compatible with
Other updated packages:
@ag-grid-community/client-side-row-model 23.2.1 ---> 26.2.0 (previous version was not compatible with react v17)
@ag-grid-community/core 23.2.1 ---> 26.2.0 (previous version was not compatible with react v17)
@ag-grid-community/react 23.2.1 ---> 26.2.0 (previous version was not compatible with react v17)
@ant-design/icons 4.2.1 --> 4.7.0
@types/react-dom 17.0.0 --->17.0.2
react-dom 16.12.0 --> 17.0.2
react-rnd 10.2.1 --> 10.3.4
typescript 4.1.3 --> 4.2.2
antd 4.15.1 --> 4.17.3
enzyme-adapter-react-16 1.15.2 ---> replaced by `@wojtekmaj/enzyme-adapter-react-17' 0.6.6 (should be replaced by official packaage once it becomes available)
react-styleguidist 11.0.8 --> 11.1.7
react-fa
was deprecated and was incompatible with react v17. Replaced by:This particular dependency replacement of FontAwesome, introduced some breaking changes on the way the icons are passed to react-geo elements. The code has been refactored to accommodate these changes, as well as the tests and documentation. Icons should now be names according to FontAwesome v5 gallery
Bugs detected on previous release on the Documentation example have also been fixed (Before ---> After)
Tests added ✔️
Docs added ✔️
Pleaase review @terrestris/devs