Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React 17 #2329

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Update to React 17 #2329

merged 1 commit into from
Dec 17, 2021

Conversation

Unraveler
Copy link
Contributor

@Unraveler Unraveler commented Dec 15, 2021

DEPENDENCY UPDATE

Description:

This PR changes previous peer dependencies making the package now compatible with

  • React v17.0
  • @types/react v17.0
  • AntDesign v4.17
  • OpenLayers v6.9

Other updated packages:

  • @ag-grid-community/client-side-row-model 23.2.1 ---> 26.2.0 (previous version was not compatible with react v17)

  • @ag-grid-community/core 23.2.1 ---> 26.2.0 (previous version was not compatible with react v17)

  • @ag-grid-community/react 23.2.1 ---> 26.2.0 (previous version was not compatible with react v17)

  • @ant-design/icons 4.2.1 --> 4.7.0

  • @types/react-dom 17.0.0 --->17.0.2

  • react-dom 16.12.0 --> 17.0.2

  • react-rnd 10.2.1 --> 10.3.4

  • typescript 4.1.3 --> 4.2.2

  • antd 4.15.1 --> 4.17.3

  • enzyme-adapter-react-16 1.15.2 ---> replaced by `@wojtekmaj/enzyme-adapter-react-17' 0.6.6 (should be replaced by official packaage once it becomes available)

  • react-styleguidist 11.0.8 --> 11.1.7

  • react-fa was deprecated and was incompatible with react v17. Replaced by:

    • @fortawesome/react-fontawesome v0.1.16
    • @fortawesome/fontawesome-svg-core v1.2.36
    • @fortawesome/free-solid-svg-icons v5.15.4
    • @fortawesome/free-brands-svg-icons v5.15.4
    • @fortawesome/free-regular-svg-icons v5.15.4

This particular dependency replacement of FontAwesome, introduced some breaking changes on the way the icons are passed to react-geo elements. The code has been refactored to accommodate these changes, as well as the tests and documentation. Icons should now be names according to FontAwesome v5 gallery

Bugs detected on previous release on the Documentation example have also been fixed (Before ---> After)

Screenshot from 2021-12-16 15-53-27

Screenshot from 2021-12-16 15-53-54

Screenshot from 2021-12-16 16-03-26

Tests added ✔️
Docs added ✔️

Pleaase review @terrestris/devs

@Unraveler Unraveler changed the title Draft: Update/dependency update for react 17 Peer dependency update for React v17.0.2 Dec 16, 2021
Copy link
Member

@dnlkoch dnlkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me so far, but please have a look at the commit messages, they must match the semantic-release-plugin conventions.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/Button/SimpleButton/SimpleButton.tsx Outdated Show resolved Hide resolved
src/Button/SimpleButton/SimpleButton.tsx Outdated Show resolved Hide resolved
src/Button/SimpleButton/SimpleButton.tsx Outdated Show resolved Hide resolved
src/Button/SimpleButton/SimpleButton.tsx Outdated Show resolved Hide resolved
src/Button/ToggleButton/ToggleButton.tsx Show resolved Hide resolved
src/Panel/Panel/Panel.example.md Outdated Show resolved Hide resolved
src/Util/fontawesome.ts Show resolved Hide resolved
@Unraveler Unraveler changed the title Peer dependency update for React v17.0.2 Peer dependency update Dec 16, 2021
@Unraveler Unraveler changed the title Peer dependency update build: Peer dependency update Dec 16, 2021
@dnlkoch
Copy link
Member

dnlkoch commented Dec 17, 2021

Reminder: The commit messages should be reformatted to meet the semantic-release prerequisites.

@dnlkoch dnlkoch force-pushed the update/dependency-update-for-react-17 branch 3 times, most recently from 7a73f9d to 1f75122 Compare December 17, 2021 15:34
…onents to become compatible with it as well

BREAKING CHANGE: This updates the peerDependency of React to version 17
@dnlkoch dnlkoch force-pushed the update/dependency-update-for-react-17 branch from 1f75122 to 5b9075e Compare December 17, 2021 15:47
@dnlkoch dnlkoch changed the title build: Peer dependency update Update to React 17 Dec 17, 2021
Copy link
Member

@dnlkoch dnlkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Unraveler!

@dnlkoch dnlkoch merged commit a0664e0 into master Dec 17, 2021
@dnlkoch dnlkoch deleted the update/dependency-update-for-react-17 branch December 17, 2021 15:56
@github-actions
Copy link

🎉 This PR is included in version 16.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants