Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build time for docker images #730

Merged
merged 4 commits into from
Sep 4, 2023
Merged

Fix build time for docker images #730

merged 4 commits into from
Sep 4, 2023

Conversation

ahennr
Copy link
Member

@ahennr ahennr commented Sep 3, 2023

Description

…by using USE_CURRENT_TIMESTAMP as creationTime config for jib plugin.

In addition, the maven git plugin is updated to version 5.0.0.

Plz review @terrestris/devs

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Tests
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    Apache Licence Version 2.0.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the code of conduct.
  • I have added or updated tests and documentation, and the test suite passes (run mvn test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@ahennr ahennr merged commit b1e0db3 into main Sep 4, 2023
4 checks passed
@ahennr ahennr deleted the docker-image-build-time branch September 4, 2023 09:09
@LukasLohoff LukasLohoff mentioned this pull request Sep 4, 2023
22 tasks
LukasLohoff added a commit to LukasLohoff/shogun that referenced this pull request Sep 5, 2023
BREAKING CHANGE: requires migration for spring / spring-security 6 and hibernate 6 updates

Migration guide:

- update java EE 8 dependencies to jakarta EE 9 (see https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0-Migration-Guide#jakarta-ee)
- update repositories
  - update `@QueryHints` annotations
  - e.g. `org.hibernate.annotations.QueryHints.CACHEABLE` -> `AvailableHints.HINT_CACHEABLE`
  - if you use custom data fetching methods, migration steps for hibernate 6 / 6.1 / 6.2 might be necessary
    - especially consider https://github.com/hibernate/hibernate-orm/blob/6.0/migration-guide.adoc#removals
    - for more information see the hibernate migration guides listed below
- update your SecurityConfigs which extend `KeycloakWebSecurityConfig` or `SimpleWebSecurityConfig`
   - update your filter chain according to the the spring security migration guides below
   - replace `antMatchers` with `requestMatchers`, ignoringAntMatchers with ignoringRequestMatchers
   - update your rules for swagger (`/v3/api-docs`) if they're not already updated
- update your `git-commit-id-plugin` configuration and check if the version set in shogun is overridden (for more information see  terrestris#730)
simonseyock pushed a commit that referenced this pull request Sep 18, 2023
# [18.0.0](v17.2.0...v18.0.0) (2023-09-18)

### Bug Fixes

* adds missing git-commit-id-maven-plugin in gs-interceptor ([a6b390a](a6b390a))
* allow extending WebSecurityConfig ([10cb4e4](10cb4e4))
* circular dependency problems ([53aa861](53aa861))
* cleanup ([2db9a60](2db9a60))
* extract xmlbind version to property ([e37392f](e37392f))
* fix http proxy tests ([b9e8be4](b9e8be4))
* fix hypersistence-utils version ([7958976](7958976))
* fix queryHints import ([7df2511](7df2511))
* optimize imports ([d0e84f5](d0e84f5))
* reenable csrfTokenRequestHandler ([b32f02c](b32f02c))
* remove commented code ([c3d5f7a](c3d5f7a))
* remove newline ([53673e0](53673e0))
* remove not needed hibernate version ([7b0abc4](7b0abc4))
* remove unneeded parameter ([4565f49](4565f49))
* reorganize imports ([6fc6f8c](6fc6f8c))
* set correct creation time for docker images ([8be68e5](8be68e5))
* temporarily allow circular references ([4aefc55](4aefc55))
* temproarily allow circular references ([98f731d](98f731d))
* update dependency versions ([e468350](e468350))
* update git-commit-id plugin ([104b0b3](104b0b3))
* update java base image ([caba9ce](caba9ce))
* update to apache httpUtil5 ([8661561](8661561))
* web security setup ([b4979bc](b4979bc))

### Features

* allow to only override security filterchain ([4b37639](4b37639))
* improve content type detection ([4b754e3](4b754e3))
* include REFERENCE_TABLE and make PropertyFormItemEditConfig abstract ([e4bbaf5](e4bbaf5))
* update for hibernate 6.1 and hibernate-types ([b105159](b105159))
* update keycloak to 21.0.1 ([f90de77](f90de77))
* update spring-boot to 3.0.x ([f95fcaf](f95fcaf))

### BREAKING CHANGES

* requires migration for spring / spring-security 6 and hibernate 6 updates

Migration guide:

- update java EE 8 dependencies to jakarta EE 9 (see https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0-Migration-Guide#jakarta-ee)
- update repositories
  - update `@QueryHints` annotations
  - e.g. `org.hibernate.annotations.QueryHints.CACHEABLE` -> `AvailableHints.HINT_CACHEABLE`
  - if you use custom data fetching methods, migration steps for hibernate 6 / 6.1 / 6.2 might be necessary
    - especially consider https://github.com/hibernate/hibernate-orm/blob/6.0/migration-guide.adoc#removals
    - for more information see the hibernate migration guides listed below
- update your SecurityConfigs which extend `KeycloakWebSecurityConfig` or `SimpleWebSecurityConfig`
   - update your filter chain according to the the spring security migration guides below
   - replace `antMatchers` with `requestMatchers`, ignoringAntMatchers with ignoringRequestMatchers
   - update your rules for swagger (`/v3/api-docs`) if they're not already updated
- update your `git-commit-id-plugin` configuration and check if the version set in shogun is overridden (for more information see  #730)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants