Integrate airbrake with datastore #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datastore/zmq/zmq.go
Outdated
| // ReportError to airbrake and logger | ||
| func (p *ZMQProducer) ReportError(message string, err error, logInfo logrus.LogInfo) { | ||
| p.airbrakeHandler.ReportLogMessage(logrus.ERROR, message, err, logInfo) | ||
| p.ReportError(message, err, logInfo) |
There was a problem hiding this comment.
Infinite recursion. Did you mean p.logger.ErrorLog?
There was a problem hiding this comment.
Same for each of the datastores.
There was a problem hiding this comment.
hmm.. my branch got messed on rebase. Fixed
| @@ -208,6 +214,7 @@ var _ = Describe("BinarySerializer", func() { | |||
| result, _ = bs.Deserialize(msgBytes, "Socket-42") | |||
| bs.Dispatch(result) | |||
| Expect(CallbackTester.counter).To(Equal(1)) | |||
| Expect(CallbackTester.errors).To(Equal(0)) | |||
There was a problem hiding this comment.
Can we test when ReportError gets called?
There was a problem hiding this comment.
Not on this test - but can we test the case that does
There was a problem hiding this comment.
would be hard to simulate this scenario in tests. Will prefer keeping the testing as is.
agbpatro
force-pushed
the
add_airbrake_to_datastore
branch
from
6c9ca55 to
8240851
Compare
patrickdemers6
approved these changes
Apr 5, 2024
Report datastore errors to airbrake. Note that it will only dispatch errors to airbrake if its actually configured otherwise func (a *AirbrakeHandler) ReportLogMessage acts as a noop.
agbpatro
force-pushed
the
add_airbrake_to_datastore
branch
from
8240851 to
c5c61d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Report datastore errors to airbrake. Note that it will only dispatch errors to airbrake if its actually configured otherwise
func (a *AirbrakeHandler) ReportLogMessageacts as a noop.Fixes # (issue)
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: